No need to be bash-specific

Bug #188070 reported by Sergey Romanov
6
Affects Status Importance Assigned to Milestone
showfsck (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

The only reason showfsck uses #!/bin/bash instead of #!/bin/sh is arithmetic evaluation.

The line NB=$(($MMC - $MC + 1)) in /usr/sbin/showfsck can be changed to NB=$(expr $MMC - $MC + 1) to make the script shell-agnostic. /usr/bin/expr is in coreutils package, which has priority 'required' both in Ubuntu and Debian.

Tags: bitesize patch

Related branches

David Futcher (bobbo)
Changed in showfsck:
assignee: nobody → bobbo
status: New → Confirmed
Revision history for this message
David Futcher (bobbo) wrote :

Debdiff for this. Also fixed some grammar in the error message.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Could this patch be forwarded to Debian too?

Revision history for this message
David Futcher (bobbo) wrote :

Sorry that debdiff was created against a development version of showfsck-1.4ubuntu1 that i had left over on my machine from the last patch. This one will work properly.

Yes this could be forwarded to Debian.

Revision history for this message
Daniel Hahler (blueyed) wrote :

Thank you for your patch.

There are a few issues though:
I could not find the package in Debian anymore?! Do you know what happened to it?
I could also not find the upstream source for it. From googling it appears that it's only in Ubuntu now.
Is this correct?
If there's a "real upstream" somewhere, please add a Homepage field to debian/control.

You should also install the patchutils package, so that the debdiff can be applied using "patch -p1".

Also, please de-assign yourself from the bug, when you're done with it.

Changed in showfsck:
importance: Undecided → Low
Revision history for this message
David Futcher (bobbo) wrote :

I dont really know where the Debian version has gone, though Vincent Danjean (original maintainer) hasnt been greatly active recently. The upstream source is http://www-id.imag.fr/Laboratoire/Membres/Danjean_Vincent/debian/pool/main/s/showfsck/showfsck_1.4.tar.gz . Ubuntu is the only distro to have this package in it as far as i can see and there is no proper homepage, just a tiny section in Vincent Danjean's debian packages page which i doubt really counts.

Changed in showfsck:
assignee: bobbo → nobody
Daniel Hahler (blueyed)
Changed in showfsck:
assignee: nobody → blueyed
status: Confirmed → In Progress
Revision history for this message
Daniel Hahler (blueyed) wrote :

Uploaded, with additional fixes in debian/control, reported by lintian.
Thanks.

Changed in showfsck:
assignee: blueyed → nobody
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package showfsck - 1.4ubuntu2

---------------
showfsck (1.4ubuntu2) hardy; urgency=low

  [ David Futcher ]
  * Made script shell-agnostic (LP: #188070)
  * showfsck: Fixed grammar error in error message
  * Fixed debian/copyright

  [ Daniel Hahler ]
  * debian/control: fix lintian warning/errors:
    - Standards-Version 3.7.3
    - Move cdbs, debhelper from Build-Depends-Indep to Build-Depends

 -- Daniel Hahler <email address hidden> Sat, 09 Feb 2008 19:00:00 +0100

Changed in showfsck:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.