fs_label not supported by ds-identify

[ov2k]

The NoCloud fs_label setting is not respected by ds-identify when set in cloud.cfg or cloud.cfg.d/*. DataSourceNoCloud.py handles the setting correctly, but ds-identify is hardcoded to only look for cidata and CIDATA.

[Ryan Harper (raharper)]

Thanks for the bug. And Thank you for providing a PR as well.

https://github.com/canonical/cloud-init/pull/386

[Chad Smith (chad.smith)]

Hrm, ov2k,

On your platform, if you provide the following file /etc/cloud/cloud.cfg.d/99_mandate_nocloud.cfg:

datasource_list: [NoCloud]

Does this allow you to honor your custom fs_label (as ds-identify should automatically set NoCloud as your datasource without testing fslabel locallly, then the python DataSourceNoCloud proper detection should work I think.

[ov2k (ov2k)]

I already identified a workaround and tore down the test environment for this, but I think your suggestion would be a viable workaround in those cases in which not running ds-identify is acceptable. I believe forcing the data source list has the side effect of causing cloud-init to run even when no suitable filesystem exists, which might cause problems for certain configurations. Working around the issue isn't fixing it.

The core issue is that the behavior of ds-identify is not consistent with the behavior of DataSourceNoCloud.py and the documentation for fs_label. In general, you can fix ds-identify, remove fs_label, or fix the documentation to make this a feature. I guess technically, you can ignore the issue as well.

[Scott Moser (smoser)]

Just to re-iterate here what was in the pull request.

https://github.com/canonical/cloud-init/pull/386

My suggestion is to remove the code that supports 'fs_label' configuration and any accompanying documentation. This was an example of a feature (implemented by me) that had no use case.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3694