EG3.5 default value for opac.hold_notify ignored

[[e-mail]]

This is related 1774268.

EG 3.5

The default value in the user setting type opac.hold_notify is not reflected on patron registration page. It's always both phone and email.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1879993-default-hold-notify-upstream uses the reg_default value for the opac.hold_notify user setting on the patron registration page:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1879993-default-hold-notify-upstream

The reg_default will also be used when editing an existing patron who has no opac.hold_notify user setting. In either case, you can use an empty string ("") as the setting value in order to keep all boxes unchecked. If there is no user setting and no default value, both phone and email will be checked, which is consistent with current behavior.

Test plan:

[1] In config.usr_setting_type, set the reg_default for opac.hold_notify to "email".
[2] Register a new patron. The default value is applied: under Hold Notices, phone is unchecked and email is checked.
[3] Edit an existing patron with no opac.hold_notify setting. The default value is applied: under Hold Notices, phone is unchecked and email is checked.
[4] Edit an existing user who *does* have an opac.hold_notify setting. The boxes will be checked in accordance with the setting.

[Michele Morgan (mmorgan)]

This works for me. I tested cases where the user_setting_type had a registration default and where there was no registration default. For both cases, I tested adding a new patron, editing a patron with preferences, and editing a patron without preferences.

My signoff is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1879993_signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_5, and rel_3_4. Thanks, Jeff and Michele!