Cannot edit carousel by Actions menu

[Tiffany Little]

Tested on 3.4.1 and a master-ish test server.

You cannot edit a carousel (Administration > Local Administration > Carousels) when either right click > Edit Carousel or from the Actions > Edit Carousel. The modal opens, but only has the header, close and save buttons. I also get this console error:

ERROR TypeError: this.showEditDialog is not a function
    at n (6.33ad017dc45e5a101cf8.js:1)
    at b.editSelected [as action] (6.33ad017dc45e5a101cf8.js:1)
    at s.performAction (5.291238da3b42df2dd458.js:1)
    at Object.handleEvent (5.291238da3b42df2dd458.js:1)
    at Object.handleEvent (main.71050b4b7a15dddcdc6f.js:1)
    at Object.handleEvent (main.71050b4b7a15dddcdc6f.js:1)
    at es (main.71050b4b7a15dddcdc6f.js:1)
    at main.71050b4b7a15dddcdc6f.js:1
    at HTMLButtonElement.<anonymous> (main.71050b4b7a15dddcdc6f.js:1)
    at l.invokeTask (polyfills.f44815c8d3b2342634c0.js:1)

The edit modal does open if you double click on the row.

[Michele Morgan (mmorgan)]

I'm seeing something slightly different than what Tiffany describes on a 3.4.3 system.

I cannot edit a carousel at all by right-clicking and choosing Edit Selected, or selecting and using the Actions menu to choose Edit Selected. No modal pops up at all. In the console I see a similar error to what Tiffany has captured above.

I am able to edit a carousel by double-clicking on the row, but if it's the first double-click performed after loading the screen, I see the modal with only the header, save and close buttons.

If I wait long enough, the rest of the modal appears. Once the modal has fully loaded once, subsequent double clicks on other rows will fully load the modal.

While waiting for the initial load of the modal, the console hangs at:

Net: request open-ils.pcrud.search.cbreb.atomic

The delay issue looks to be covered by bug 1851884.

The inability to edit using a right-click or the Actions menu still needs to be addressed by this bug.

[Terran McCanna (tmccanna)]

This works for me on my local test server:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1879769_cannot_edit_carousel_from_actions

(The lag time in comment #1 is a different issue.)

[Gina Monti (gmonti90)]

I, Gina Monti, sign off on this bug fix. Editing carousels now works either through actions or right-clicking the carousel.

[Galen Charlton (gmc)]

Pushed all the way to rel_3_6. Thanks, Terran and Gina!