Memory leak in CueDAO
Bug #1879186 reported by
Daniel Schürmann
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
High
|
Unassigned | ||
Bug Description
CueDAO::m_cues holds a strong reference to all cue points in the database and is never freed.
1.3 MB are lost after playing one track.
I am not sure if this is reasonable to keep, because we have a track cache anyway. This also holds strong references to the cue points via the Track object.
Originally it was a list of raw pointers. Can it become a list of weak pointers?
Revision history for this message
| Uwe Klotz (uklotzde-deactivatedaccount) wrote | #1 |
| Changed in mixxx: | |
| milestone: | none → 2.3.0 |
| importance: | Undecided → High |
| Changed in mixxx: | |
| assignee: | nobody → Uwe Klotz (uklotzde) |
Revision history for this message
| Uwe Klotz (uklotzde-deactivatedaccount) wrote | #2 |
| Changed in mixxx: | |
| status: | New → In Progress |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #3 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
From what I have seen it doesn't make any sense to cache these objects. Should be removed entirely.