Upgrade rabbitmq-server to v3.8.3 from upstream

[Nicolas Bock]

rabbitmq-server FTBFS in Groovy, and needs to be upgraded to latest from upstream.

Also the current debian/watch file downloads from an outdated location. Update the watch file so it gets the sources directly from GitHub.

[Nicolas Bock (nicolasbock)]

Updated author email in debdiff

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "groovy-4.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Eric Desrochers (slashd)]

Thanks Nicolas, a few notes here.

Could you please submit it to both upstream and debian ?

https://github.com/rabbitmq/rabbitmq-server-release/blob/master/packaging/debs/Debian/debian/watch

https://salsa.debian.org/openstack-team/third-party/rabbitmq-server/-/blob/debian/ussuri/debian/watch

Did you follow this documentation to update d/watch ?
https://wiki.debian.org/debian/watch

Did you verify/test it ?
uscan - scan/watch upstream sources for new releases of software

$ cd SRC_PKG (w/ your debian/watch change)
$ uscan --verbose -report

Did you run a lintian report again the .dsc file ?
If yes, was there any report with regards to your debian/watch change ?

$ lintian -EvIL +pedantic <SRC_PKG>.dsc

[Nicolas Bock (nicolasbock)]

I pushed the package to https://launchpad.net/~nicolasbock/+archive/ubuntu/rabbitmq-server. However, it's not building because (I think) the makefile is trying to download a ton of dependencies from GitHub. How is that normally fixed?

[Dan Streetman (ddstreet)]

with the minor d/watch tweak we talked about in irc, LGTM thanks @nicolasbock! Uploaded to groovy.

[Eric Desrochers (slashd)]

Since rabbitmq-server is a critical package and the (merge) upstream bump has already been made.

Would it be possible to when time permit modernize (or at least evaluate it) the packaging aspect ? It's the perfect time to do so before groovy become stable in October.

I see this as work we do now, to save/help us maintain the package in a support way later.

For instance ...

* Current package uses dh 10, when dh 13 is available now.
* A few deprecated things here and there.
* It has no autopkgtest and it seems like upstream has a testsuite we can use:
https://github.com/rabbitmq/rabbitmq-test
* Few copyright issues

Here's the full report:
$ lintian -EvIL +pedantic

E: rabbitmq-server source: source-is-missing deps/rabbitmq_management/priv/www/js/singular/rpFrame.js line length is 32768 characters (>512)
E: rabbitmq-server source: source-is-missing deps/rabbitmq_management/priv/www/js/singular/singular.js line length is 32768 characters (>512)

W: rabbitmq-server source: debian-rules-uses-unnecessary-dh-argument dh ... --with=systemd (line 11)
W: rabbitmq-server source: obsolete-url-in-packaging debian/copyright http://code.google.com/p/glmatrix/

I: rabbitmq-server source: debian-rules-parses-dpkg-parsechangelog (line 5)
I: rabbitmq-server source: out-of-date-standards-version 4.2.1 (released 2018-08-25) (current is 4.5.0)
I: rabbitmq-server source: testsuite-autopkgtest-missing
I: rabbitmq-server source: unused-file-paragraph-in-dep5-copyright paragraph at line 39
I: rabbitmq-server source: unused-file-paragraph-in-dep5-copyright paragraph at line 44
I: rabbitmq-server source: unused-file-paragraph-in-dep5-copyright paragraph at line 49
I: rabbitmq-server source: unused-file-paragraph-in-dep5-copyright paragraph at line 55
I: rabbitmq-server source: wildcard-matches-nothing-in-dep5-copyright deps/mochiweb/* (paragraph at line 44)
I: rabbitmq-server source: wildcard-matches-nothing-in-dep5-copyright deps/rabbit_common/src/ec_semver.erl (paragraph at line 55)
I: rabbitmq-server source: wildcard-matches-nothing-in-dep5-copyright deps/rabbit_common/src/ec_semver_parser.erl (paragraph at line 55)
I: rabbitmq-server source: wildcard-matches-nothing-in-dep5-copyright deps/rabbitmq_management_visualiser/priv/www/visualiser/js/glMatrix*.js (paragraph at line 49)
I: rabbitmq-server source: wildcard-matches-nothing-in-dep5-copyright deps/webmachine/* (paragraph at line 39)

X: rabbitmq-server source: debian-watch-does-not-check-gpg-signature

P: rabbitmq-server source: package-uses-deprecated-source-override-location
P: rabbitmq-server source: package-uses-old-debhelper-compat-version 10
P: rabbitmq-server source: rules-requires-root-missing
P: rabbitmq-server source: source-contains-prebuilt-java-object deps/rabbitmq_auth_backend_http/examples/rabbitmq_auth_backend_spring_boot/.mvn/wrapper/maven-wrapper.jar
P: rabbitmq-server source: source-contains-prebuilt-java-object deps/rabbitmq_auth_backend_http/examples/rabbitmq_auth_backend_spring_boot_kotlin/.mvn/wrapper/maven-wrapper.jar
P: rabbitmq-server source: source-contains-prebuilt-javascript-object deps/rabbitmq_management/priv/www/js/ejs-1.0.min.js
P: rabbitmq-server source: source-contains-preb...