undercloud upgrade: packages are updated before asking user confirmation

[Emilien Macchi]

When running "openstack undercloud upgrade" (without -y / --yes), usually no action would be done before the user confirms that upgrade is ready to be performed. However we run the package update before asking; which could be problematic in some cases when the user called that command by mistake.

Regression from:
https://review.opendev.org/#/c/718784/
and its backport: https://review.opendev.org/#/c/717719/

[Alex Schultz (alex-schultz)]

We likely need to backport https://review.opendev.org/#/c/718784/ which is an improvement over the other patch.

[Alex Schultz (alex-schultz)]

oh nm it's caused by that because the Y/n is handled elsewhere. we need to move that logic up

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/726893

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/726893
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c0b0a5aa6770028777e19e0e7ac833f8cb5575ae
Submitter: Zuul
Branch: master

commit c0b0a5aa6770028777e19e0e7ac833f8cb5575ae
Author: Alex Schultz <email address hidden>
Date: Mon May 11 10:07:51 2020 -0600

    Fix upgrade prompt

    We need to prompt the user if we should upgrade earlier in the code so
    we can handle additional things like package upgrades in the undercloud
    upgrade after the prompt. This change pulls the confirmation logic out
    of tripleo_deploy and reuses the prompt_user_for_confirmation code in
    the tripleo upgrade and undercloud upgrade actions.

    Change-Id: I8dbcae39e6f6d966c1337bad5fb5ba673f7be874
    Closes-Bug: #1877825

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/727887

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727887
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=f0c8e5f16ed0e30503349666fec804a414ad60af
Submitter: Zuul
Branch: stable/train

commit f0c8e5f16ed0e30503349666fec804a414ad60af
Author: Alex Schultz <email address hidden>
Date: Mon May 11 10:07:51 2020 -0600

    Fix upgrade prompt

    We need to prompt the user if we should upgrade earlier in the code so
    we can handle additional things like package upgrades in the undercloud
    upgrade after the prompt. This change pulls the confirmation logic out
    of tripleo_deploy and reuses the prompt_user_for_confirmation code in
    the tripleo upgrade and undercloud upgrade actions.

    Change-Id: I8dbcae39e6f6d966c1337bad5fb5ba673f7be874
    Closes-Bug: #1877825
    (cherry picked from commit c0b0a5aa6770028777e19e0e7ac833f8cb5575ae)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.