review-submit doesn't support dependant branches

[Graham Binns]

When submitting a branch which depends on another branch for review, the user should be able to specify this at the command line. For example:

$ bzr review-submit -r <email address hidden> --depends=bzr+ssh://path/to/other/branch

The diff should then be generated against the dependency rather than the default parent for the branch being submitted.

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Graham Binns wrote:
> Public bug reported:
>
> When submitting a branch which depends on another branch for review, the
> user should be able to specify this at the command line. For example:
>
> $ bzr review-submit -r <email address hidden>
> --depends=bzr+ssh://path/to/other/branch
>
> The diff should then be generated against the dependency rather than the
> default parent for the branch being submitted.

Actually, the submitted branch may be more up-to-date with the trunk
than the dependency. In that case, the changes introduced into trunk
after the dependency merged it will show as changes introduced by the
submitted branch.

Ideally, the diff would be against a version of trunk with the
dependency merged into it.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHol7I0F+nu1YWqI0RAuJYAKCHlCOi7XUS0dkR+2k4TkLuDo+eIACgiUIV
45iMqiXIksx+LOX3DONjlhw=
=YN63
-----END PGP SIGNATURE-----

[Michael Hudson-Doyle (mwhudson)]

Aaron, do you think that a PreviewTree will work as the target branch for a merge?

Because if it does, I think you can make this work by making a preview tree, let's call it P1, of the merge of the dependent branch into the target branch, then making another preview tree, P2, by merging the source branch into P1, then displaying the diff between P1 and P2. But I'd like to know if this approach has any hope before I starting trying things...

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Hudson wrote:
> Aaron, do you think that a PreviewTree will work as the target branch
> for a merge?

I think it will need to support the full Tree interface before that
works, which is a good idea, but a fair amount of work. The interface
doesn't have a crazy number of methods, but some would be tricky to
implement efficiently.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHppai0F+nu1YWqI0RAq+DAJ9Tu2QL2eoMRYpRmmOSv5YRWae/mgCgiVNw
wG43Z1aFRKOMk+DL+uS7H6k=
=5PBS
-----END PGP SIGNATURE-----