networking_odl.tests.functional.test_odl_dhcp_driver.TestOdlDhcpDriver.test_subnet_delete fails constantly

[Lajos Katona]

networking_odl.tests.functional.test_odl_dhcp_driver.TestOdlDhcpDriver.test_subnet_delete fails constantly both on master both on freshly cut stable/ussuri branch.
The problem is that after subnet deletion the test checks if the dhcp port was deleted, but the port is still there.

It seems that the issue was introduced by https://review.opendev.org/713045 (Lock subnets during port creation and subnet deletion)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/724656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/725533

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/724656
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=ef420a935d042e47b21d5fa7a2e3cf048b2935ad
Submitter: Zuul
Branch: master

commit ef420a935d042e47b21d5fa7a2e3cf048b2935ad
Author: elajkat <email address hidden>
Date: Thu Apr 30 08:33:40 2020 +0200

    Add subnet deleted handler

    With [0] neutron introduced a mechanism to lock subnets and avoid
    deletion of used subnets (see [1] for the bug details). As a side effect
    this caused that after subnet deletion dhcp ports was not deleted as
    no trigger arrived to call handle_port_update_event.

    [0] https://review.opendev.org/713045
    [1] https://bugs.launchpad.net/neutron/+bug/1865891

    Change-Id: I3aed8031c1b784c16dd7055afd41456ed935b7fc
    Related-Bug: #1865891
    Closes-Bug: #1876033

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/725533
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=d31b0ef9319dacc7cd4cc89e7963f2a1e82df1fa
Submitter: Zuul
Branch: stable/ussuri

commit d31b0ef9319dacc7cd4cc89e7963f2a1e82df1fa
Author: elajkat <email address hidden>
Date: Thu Apr 30 08:33:40 2020 +0200

    This change is a squash of 2 different patches to pass the gate

    1) Backport of subnet deleted handler
    With [0] neutron introduced a mechanism to lock subnets and avoid
    deletion of used subnets (see [1] for the bug details). As a side effect
    this caused that after subnet deletion dhcp ports was not deleted as
    no trigger arrived to call handle_port_update_event.
    [0] https://review.opendev.org/713045
    [1] https://bugs.launchpad.net/neutron/+bug/1865891
    (cherry picked from commit ef420a935d042e47b21d5fa7a2e3cf048b2935ad)
    Related-Bug: #1865891
    Closes-Bug: #1876033

    2) fix pep8 issues which mostly come from new version of isort
    Fix pep8 job and small fixes for functional jobs
    New versions of isort broke pylint. This patch fixes it at 4.3.21.
    The issue appeared on stable branches that functional jobs can't find
    correct pip version and failed due to not actual neutron version.
    Add mock to functional requirements.txt to make sure that neutron has it
    in functional envrionment.
    (cherry picked from commit e4367d791702c3e40a3796dd753b58546599cef8)

    Change-Id: I3aed8031c1b784c16dd7055afd41456ed935b7fc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/745806

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/745806
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl ussuri-eol release.