'Login' button not visible in 'Default' theme when only a link

Bug #1875267 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned

Bug Description

When you have set the following in your config.php file:

$cfg->showloginsideblock = false;

the 'Login' link at the top right is not visible in the header in the 'Default' theme. All other themes show 'Login'.

The display can be improved though. For example, in the primary, modern, and ocean themes, the button that comes up during hover is not standing out much.

In the past, the language selector was placed to the left of the 'Login' link. Now it is to the right of it. It would be better to have it to the left again so that the 'Login' link as the most important element is in the easier accessible location.

tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10935

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10935
Committed: https://git.mahara.org/mahara/mahara/commit/91404add7b226937fb17be87f51d8e1829cd422e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 91404add7b226937fb17be87f51d8e1829cd422e
Author: Evonne <email address hidden>
Date: Tue Apr 28 10:13:39 2020 +1200

Bug 1875267 'Login' button not visible in 'Default' theme when only a link

Raw was using the wrong variables, changed to the header toggle colour and
background variables. Also made it bold to stand out and changed the order
so login is far right.

behatnotneeded

Change-Id: Idef5be90b3861edabcaab7e5303d898a6e247fcf

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10940

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10940
Committed: https://git.mahara.org/mahara/mahara/commit/32f235daf90fa69e96dcf2ba9cb65b1471fbf5d9
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 32f235daf90fa69e96dcf2ba9cb65b1471fbf5d9
Author: Evonne <email address hidden>
Date: Tue Apr 28 10:13:39 2020 +1200

Bug 1875267 'Login' button not visible in 'Default' theme when only a link

Raw was using the wrong variables, changed to the header toggle colour and
background variables. Also made it bold to stand out and changed the order
so login is far right.

behatnotneeded

Change-Id: Idef5be90b3861edabcaab7e5303d898a6e247fcf
(cherry picked from commit 91404add7b226937fb17be87f51d8e1829cd422e)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04rc2 → 20.04.0
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.