kolla-ansible

haproxy still restarted twice

Bug #1875228 reported by Radosław Piliszek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Low
Radosław Piliszek
kolla-ansible 10.0.0 "ussuri"
Stein
Fix Released
Low
Unassigned
kolla-ansible 8.2.0 "stein"
Train
Fix Released
Low
Unassigned
kolla-ansible 9.2.0 "Train"
Ussuri
Fix Released
Low
Radosław Piliszek
kolla-ansible 10.0.0 "ussuri"

Bug Description

Even after https://review.opendev.org/#/q/topic:haproxy-config-avoid-multiple-haproxy-restarts we get haproxy restarted twice per host - this is due to flush handlers in haproxy role.

Since haproxy is orchestrated via site.yml in a single play, it should probably not need it in there at all as handlers run will happen at end of play.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/723258

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/723258
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=04effaa9032b052343e3cf82a65054f0d35834ea
Submitter: Zuul
Branch: master

commit 04effaa9032b052343e3cf82a65054f0d35834ea
Author: Radosław Piliszek <email address hidden>
Date: Sun Apr 26 21:51:20 2020 +0200

    Fix haproxy restarting twice per Ansible run

    Since haproxy is orchestrated via site.yml in a single play,
    it does not need flushing handlers as handlers run will
    happen at the end of this play.

    Change-Id: Ia3743575da707325be93c39b4a2bcae9211cacb2
    Related-Bug: #1864810
    Closes-Bug: #1875228

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/723553

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/723611

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/723553
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=e2fd048430e9833c6c3eaf6e560001adc775c08d
Submitter: Zuul
Branch: stable/train

commit e2fd048430e9833c6c3eaf6e560001adc775c08d
Author: Radosław Piliszek <email address hidden>
Date: Sun Apr 26 21:51:20 2020 +0200

    Fix haproxy restarting twice per Ansible run

    Since haproxy is orchestrated via site.yml in a single play,
    it does not need flushing handlers as handlers run will
    happen at the end of this play.

    Change-Id: Ia3743575da707325be93c39b4a2bcae9211cacb2
    Related-Bug: #1864810
    Closes-Bug: #1875228
    (cherry picked from commit 04effaa9032b052343e3cf82a65054f0d35834ea)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/723611
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=5f563ed490aa63fd2e4551ca558ce6fe860d2179
Submitter: Zuul
Branch: stable/stein

commit 5f563ed490aa63fd2e4551ca558ce6fe860d2179
Author: Radosław Piliszek <email address hidden>
Date: Sun Apr 26 21:51:20 2020 +0200

    Fix haproxy restarting twice per Ansible run

    Since haproxy is orchestrated via site.yml in a single play,
    it does not need flushing handlers as handlers run will
    happen at the end of this play.

    Change-Id: Ia3743575da707325be93c39b4a2bcae9211cacb2
    Related-Bug: #1864810
    Closes-Bug: #1875228
    (cherry picked from commit 04effaa9032b052343e3cf82a65054f0d35834ea)

tags: added: in-stable-stein
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.