When clicking a group label on 'All groups' screen, switch to 'All my groups' screen

Bug #1875118 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

When you are on 'Groups' and the search context is 'All groups', then you can still click the labels that you had assigned to a group, but you don't see a difference on the screen. That's because the filtering only happens when the search context is 'All my groups', 'Groups I'm in', 'Groups I own'.

When a label is clicked on the 'All groups' context, then the search context should change to 'All my groups' and display the filtered result list.

To replicate:

1. PersonA sets up 3 groups (2 of which are controlled groups, one is open) and adds PersonB to the 2 controlled groups.
3. PersonB creates a group.
4. Person B labels 1 group in which they are a member and their own group with 'testing'.
5. On Main menu -> Engage -> Groups, PersonB selects the search context 'All groups' and verifies that they can see all groups.
6. PersonB clicks on the label 'testing' in one of the two groups.
Expected result: The result list is filtered by the label and the search context is changed to 'All my groups' as 'All groups' doesn't display the filter.
Actual result: Nothing happens.

Revision history for this message
Robert Lyon (robertl-9) wrote :

I tried to replicate this with the instructions given and it worked for me as expected (in Firefox and Chromium)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10942

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10942
Committed: https://git.mahara.org/mahara/mahara/commit/8df65906fcb8298b8710ee017fd13300b51cadb5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8df65906fcb8298b8710ee017fd13300b51cadb5
Author: Robert Lyon <email address hidden>
Date: Wed Apr 29 09:42:51 2020 +1200

Bug 1875118: Group label filter correctly

When on 'All groups' list and clicking a label we now get taken to
'All my groups' as only ones own groups can have labels and the
filtering takes place there.

Change-Id: I1bf5af0e37fe1a189b2700bae3137d2fd87de283
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10947

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10947
Committed: https://git.mahara.org/mahara/mahara/commit/8836fcfc7c4c9bc41885c96a472220f0a999c044
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 8836fcfc7c4c9bc41885c96a472220f0a999c044
Author: Robert Lyon <email address hidden>
Date: Wed Apr 29 09:42:51 2020 +1200

Bug 1875118: Group label filter correctly

When on 'All groups' list and clicking a label we now get taken to
'All my groups' as only ones own groups can have labels and the
filtering takes place there.

Change-Id: I1bf5af0e37fe1a189b2700bae3137d2fd87de283
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 8df65906fcb8298b8710ee017fd13300b51cadb5)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: 20.04rc2 → 20.04.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.