Angular staff catalog fails to honor cat.default_classification_scheme in bib summary.

[Bill Erickson]

Evergreen 3.4

The default classification scheme is hard-coded to "1" in the staff catalog. From the bib summary code:

// TODO labelClass = cat.default_classification_scheme YAOUS
const labelClass = 1;

For improved future-proofing, I'd propose we modify this API:

open-ils.cat.biblio.record.marc_cn.retrieve

If no $class is provided by the caller, it should lookup the default classification and use it if found, finally falling back to the fields defined inline.

[Bill Erickson (berick)]

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1874897-staffcat-def-classification-scheme

To test,

1. Set a value for the org unit setting "cat.default_classification_scheme" which is not "1" and which refers to a valid "asset.call_number_class" row. You may have to create/modify one to produce meaningfully different results in the UI.

2. Load a record in the detail page (e.g. /eg2/en-US/staff/catalog/record/248) and confirm the "Bib Call #" matches the scheme.

[Jane Sandberg (sandbergja)]

Works well for me. Thanks, Bill! Signoff here: user/sandbergja/lp1874897-staffcat-def-classification-scheme-signoff

For other testers, here's something that tripped me up. The cat.default_classification_scheme doesn't apply to your workstation's org unit, but to your workstation's default search library. In particular, if you are testing this with admin/demo123-type credentials, your default search library may be CONS, even if your workstation ou is, say, BR1.

[Galen Charlton (gmc)]

Pushed to master, rel_3_5, and rel_3_4. Thanks, Bill and Jane!

[John Yorio (jyorio)]

Not sure if I should put this here or on a new ticket, but I'm seeing this happen again in 3.8 - default classification scheme is Dewey but LC call number displays in bib summary.

When I use Search the Catalog (Traditional), it works correctly and displays the Dewey value.