dry-run fails on remote deployment file slurp

[Emilien Macchi]

Reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1823875

Description of problem: The dry run verification test fails. Error seen in logs is:

TASK [Slurp remote deployment file for CADeployment] ***************************
fatal: [compute-0]: FAILED! => {"changed": false, "msg": "file not found: /var/lib/heat-config/tripleo-config-download/CADeployment-203ec661-9a60-405f-9104-9428e4918e41.rendered"}
fatal: [controller-0]: FAILED! => {"changed": false, "msg": "file not found: /var/lib/heat-config/tripleo-config-download/CADeployment-3da1d640-f1a0-46a2-9af7-739efd6fe15e.rendered"}
fatal: [controller-2]: FAILED! => {"changed": false, "msg": "file not found: /var/lib/heat-config/tripleo-config-download/CADeployment-364796c0-92e7-4a1f-85ce-9ef9ab37ab8b.rendered"}
fatal: [controller-1]: FAILED! => {"changed": false, "msg": "file not found: /var/lib/heat-config/tripleo-config-download/CADeployment-95138656-af3e-4fa9-a8c3-a88f028b8008.rendered"}
fatal: [compute-1]: FAILED! => {"changed": false, "msg": "file not found: /var/lib/heat-config/tripleo-config-download/CADeployment-06d95d9a-f44e-4753-bfcd-69f10f03909e.rendered"}

Version-Release number of selected component (if applicable): RHOS_TRUNK-16.0-RHEL-8-20200406.n.1

How reproducible: Every time a jenkins job DFG-df-rfe-16-virsh-3cont_2comp_3ceph-dry-run-verification is executed

Steps to Reproduce:
1. Execute jenkins dry run verification job: DFG-df-rfe-16-virsh-3cont_2comp_3ceph-dry-run-verification
2.
3.

Actual results: dry run verification fails

Expected results: dry run verification is successful

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/721734

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/721734
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d0d8ba6b8e6616565fe0e66df83c3fbddcae9b4e
Submitter: Zuul
Branch: master

commit d0d8ba6b8e6616565fe0e66df83c3fbddcae9b4e
Author: Emilien Macchi <email address hidden>
Date: Tue Apr 21 17:07:21 2020 -0400

    Fix deployments playbook to work in check mode

    Fix the slurp task which isn't supposed to be run in check mode; since
    the rendered files don't exist.

    Also fix the tasks which try to consume a variable that might not be
    registered if the playbook was run in check mode.

    Closes-Bug: #1874141
    Change-Id: Idebcb30d80acf464b795ba219eaffe2f18fecb31

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/722161

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/722161
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a04357b1925dc403a612a805833433c2c716877e
Submitter: Zuul
Branch: stable/train

commit a04357b1925dc403a612a805833433c2c716877e
Author: Emilien Macchi <email address hidden>
Date: Tue Apr 21 17:07:21 2020 -0400

    Fix deployments playbook to work in check mode

    Fix the slurp task which isn't supposed to be run in check mode; since
    the rendered files don't exist.

    Also fix the tasks which try to consume a variable that might not be
    registered if the playbook was run in check mode.

    Closes-Bug: #1874141
    Change-Id: Idebcb30d80acf464b795ba219eaffe2f18fecb31
    (cherry picked from commit d0d8ba6b8e6616565fe0e66df83c3fbddcae9b4e)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/763549