FTBFS: Syncing the latest from Debian would fix it
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| gpick (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The version of gpick in Focal {0.2.6~rc1-1} fails to build from source, I think due to a bug in building with scons which was connected to the switch from Python 2 to Python 3.
I have uploaded a test version of the latest package in Debian {0.2.6~rc1-3} to my ppa and it builds fine:
https:/
I am not a user of the package, but I am reporting this bug in a Live session of the last Focal Daily ISO for Ubuntu Studio, and both the old version and test version seem to run fine.
Perhaps this could wait until after release (maybe an SRU with only the scons patch)? But the other changes are mainly Debian packaging QA stuff which should do no harm (except maybe for the addition of an autopkgtest). Unfortunately, the Debian Developer forgot to close the FTBFS in the changelog. That bug is here:
https:/
If the Release Team agree, I will sync it now.
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -1,3 +1,39 @@
+gpick (0.2.6~
+
+ * Test latest Debian release in ppa
+
+ -- Ross Gammon <email address hidden> Sun, 19 Apr 2020 11:32:17 +0200
+
+gpick (0.2.6~rc1-3) unstable; urgency=medium
+
+ * debian/tests
+ + testsuite process with xvfb X server
+ * debian/control
+ + Remove libdbus-glib-1-dev under Build-Depends (Closes: #955844)
+ * debian/salsa-ci
+ + Add variables to customizing REPROTEST process
+ * debian/patches
+ + 07_environment_
+
+ -- ElÃas Alejandro Año Mendoza <email address hidden> Tue, 07 Apr 2020 12:07:03 -0500
+
+gpick (0.2.6~rc1-2) unstable; urgency=medium
+
+ * Update Standards-Version to 4.5.0
+ * debian/control
+ + Add Rules-Requires-
+ * debian/tests
+ + Add to perform a simple test
+ * debian/upstream
+ + Add DEP-12 metadata
+ * debian/salsa-ci
+ + Add configuration file
+ * debian/patches
+ + 05_scons_
+ + 06_fix_
+
+ -- ElÃas Alejandro Año Mendoza <email address hidden> Mon, 23 Mar 2020 20:12:37 -0500
+
gpick (0.2.6~rc1-1) unstable; urgency=medium
* New upstream release
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -3,10 +3,11 @@
Priority: optional
Maintainer: ElÃas Alejandro Año Mendoza <email address hidden>
Build-Depends: debhelper-compat (= 12), scons, libcairo2 (>=1.6),
- libglib2.0-0 (>=2.16), libdbus-glib-1-dev (>=0.76), libgtk2.0-dev (>= 2.12),
- liblua5.2-dev (>= 5.2), libboost-dev, libexpat1-dev, lemon, flex, ragel, gettext,
+ libglib2.0-0 (>=2.16), libgtk2.0-dev (>= 2.12), liblua5.2-dev (>= 5.2),
+ libboost-dev, libexpat1-dev, lemon, flex, ragel, gettext,
libboost-
-Standards-Version: 4.4.0.1
+Standards-Version: 4.5.0
+Rules-
Homepage: http://
Vcs-Git: https:/
Vcs-Browser: https:/
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -13,17 +13,21 @@
import SCons
import re
import string
-@@ -186,10 +187,11 @@ class GpickEnvironmen
+@@ -186,11 +187,12 @@ class GpickEnvironmen
commit_date = time.gmtime(
rev_date = time.strftime(
rev_time = time.strftime(
-+ build_date = datetime.
- self.Replace(
- GPICK_BUILD_
+- self.Replace(
+- GPICK_BUILD_
- GPICK_BUILD_DATE = rev_date,
- GPICK_BUILD_TIME = rev_time,
-+ GPICK_BUILD_DATE = build_date.
-+ GPICK_BUILD_TIME = build_date.
- );
+- );
++ build_date = datetime.
++ self.Replace(
++ GPICK_BUILD_
++ GPICK_BUILD_DATE = build_date.
++ GPICK_BUILD_TIME = build_date.
++ );
def RegexEscape(str):
+ return str.replace('\\', '\\\\')
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -0,0 +1,116 @@
+Description: it allows support scons with python3
+ Fix building error because scons scripts doesn't
+ support python3
+Author: Dominique Leuenberger <email address hidden>
+Last-Updated: 2020-03-23
+
+--- gpick.orig/
++++ gpick/SConscript
+@@ -49,19 +49,19 @@ env.AddCustomBu
+ env.GetVersionI
+
+ try:
+- umask = os.umask(022)
++ umask = os.umask(0o022)
+ except OSError: # ignore on systems that don't support umask
+ pass
+
+-if os.environ.
++if 'CC' in os.environ:
+ env['CC'] = os.environ['CC']
+-if os.environ.
++if 'CFLAGS' in os.environ:
+ env['CCFLAGS'] += SCons.Util.
+-if os.environ.
++if 'CXX' in os.environ:
+ env['CXX'] = os.environ['CXX']
+-if os.environ.
++if 'CXXFLAGS' in os.environ:
+ env['CXXFLAGS'] += SCons.Util.
+-if os.environ.
++if 'LDFLAGS' in os.environ:
+ env['LINKFLAGS'] += SCons.Util.
+
+ if not env.GetOption(
+@@ -97,7 +97,7 @@ if not env.GetOption(
+ Decider(
+
+ if not env['TOOLCHAIN'] == 'msvc':
+- if not (os.environ.
++ if not ('CFLAGS' in os.environ or 'CXXFLAGS' in os.environ or 'LDFLAGS' in os.environ):
+ if env['DEBUG']:
+ env.Append(
+ CPPFLAGS = ['-Wall', '-g3', '-O0'],
+Index: gpick/source/
+======
+--- gpick.orig/
++++ gpick/source/
+@@ -50,7 +50,7 @@ if local_env[
+ else:
+ local_env.
+ objects.
+-elif local_env[
++elif local_env[
+ local_env.
+ elif local_env[
+ local_env.
+Index: gpick/tools/
+======
+--- gpick.orig/
++++ gpick/tools/
+@@ -7,12 +7,12 @@ import re
+ import string
+ import glob
+ import subprocess
+-from lemon import *
+-from flex import *
+-from gettext import *
+-from resource_template import *
+-from ragel import *
+-from template import *
++from tools.lemon import *
++from tools.flex import *
++from tools.gettext import *
++from tools.resource_
++from tools.ragel import *
++from tools.template import *
+ from SCons.Script import *
+ from SCons.Util import *
+ from SCons.Script.
+@@ -101,9 +101,9 @@ class GpickEnvironmen
+ def ConfirmPrograms
+ conf.AddTests(
+
+- for evar, args in programs.
++ for evar, args in programs.items():
+ found = False
+- for name, member_name in args['checks'
++ for name, member_name in args['checks'
+ if conf.CheckProgr
+ found = True;
+ break
+@@ -117,9 +117,9 @@ class GpickEnvironmen
+ def ConfirmLibs(self, conf, libs):
+ conf.AddTests(
+
+- for evar, args in libs.iteritems():
++ for evar, args in libs.items():
+ found = False
+- for name, version in args['checks'
++ for name, version in args['checks'
+ if conf.CheckPKG(name + ' ' + version):
+ self[evar]=name
+ found = True;
+@@ -156,9 +156,9 @@ class GpickEnvironmen
+ self.AddPostAct
+ return dir
+
+- InstallProgram = lambda self, dir, source: GpickEnvironmen
+- InstallData = lambda self, dir, source: GpickEnvironmen
+- InstallDataAutoDir = lambda self, dir, relative_dir, source: GpickEnvironmen
++ InstallProgram = lambda self, dir, source: GpickEnvironmen
++ InstallData = lambda self, dir, source: GpickEnvironmen
++ InstallDataAutoDir = lambda self, dir, relative_dir, source: GpickEnvironmen
+
+ def GetSourceFiles(
+ dir_exclude_prog = re.compile(
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -0,0 +1,16 @@
+Description: it allows fix indentation error
+ Fix indentation error into SConscript
+Author: ElÃas Alejandro Año Mendoza <email address hidden>
+Last-Updated: 2020-03-23
+
+--- gpick.orig/
++++ gpick/source/
+@@ -9,7 +9,7 @@ local_env = env.Clone()
+ if not local_env.
+ if not env['USE_GTK3']:
+ local_env.
+- else:
++ else:
+ local_env.
+
+ if not env['BUILD_TARGET'] == 'win32':
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -0,0 +1,26 @@
+Description: Setting missing environment variables
+ Update values for environment variables to get information
+ about version and revision
+Author: ElÃas Alejandro Año Mendoza <email address hidden>
+Last-Updated: 2020-04-07
+
+--- gpick.orig/
++++ gpick/source/
+@@ -2,12 +2,15 @@
+
+ import os
+ import sys
++import time
++import datetime
+
+ Import('*')
+ local_env = env.Clone()
++build_date = datetime.
+
+-local_
+- 'BUILD_REVISION': env['GPICK_
++local_
++ 'BUILD_REVISION': 'unknown',
+ 'BUILD_PLATFORM': sys.platform,
+ 'BUILD_VERSION': env['GPICK_
+ })
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -1,3 +1,6 @@
01_reproducibl
02_desktop_
04_appdata_
+05_scons_
+06_fix_
+07_environment
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -0,0 +1,7 @@
+include:
+ - https:/
+ - https:/
+
+variables:
+ SALSA_CI_
+ SALSA_CI_
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -0,0 +1,3 @@
+Tests: version
+Depends: gpick, xvfb, xauth
+Restrictions: allow-stderr
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -0,0 +1,4 @@
+#!/bin/sh
+set -e
+
+xvfb-run -a gpick --version
diff -Nru gpick-0.
--- gpick-0.
+++ gpick-0.
@@ -0,0 +1,7 @@
+Name: gpick
+Cite-As: gpick
+Contact: https:/
+Repository: https:/
+Repository-Browse: https:/
+Bug-Database: https:/
+Bug-Submit: https:/
| description: | updated |
| Steve Langasek (vorlon) wrote | #1 |
| Changed in gpick (Ubuntu): | |
| status: | New → Fix Released |
This didn't get done for focal, but groovy now has the newer gpick.