[bionic][autopkgtest] ipset failing autopkgtest after kmod sru

[Rafael David Tinoco]

At http://autopkgtest.ubuntu.com/packages/i/ipset/bionic/amd64:

we have:

working:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/i/ipset/20181112_225723_da30d@/log.gz

not working:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/i/ipset/20200320_201927_3da7c@/log.gz

and it has been 2 years between the runs, so something might have caused a regression for ipset:

hash:net6,port,net6: Range: Add zero valued element: FAILED
Failed test: /sbin/ipset 2>.foo.err -A test 2:0:0::1/24,0,0:0:0::0/0

[Rafael David Tinoco (rafaeldtinoco)]

$ rmadison ipset

 ipset | 6.11-2 | precise/universe |
 ipset | 6.20.1-1 | trusty/universe |
 ipset | 6.29-1 | xenial |
 ipset | 6.34-1 | bionic |
 ipset | 7.1-0ubuntu1 | disco |
 ipset | 7.1-0ubuntu1 | eoan |
 ipset | 7.5-1~exp1 | focal |

[Rafael David Tinoco (rafaeldtinoco)]

Was able to reproduce:

hash:net6,port,net6: Range: Create a set: passed
hash:net6,port,net6: Range: Add zero valued element: FAILED
Failed test: /sbin/ipset 2>.foo.err -A test 2:0:0::1/24,0,0:0:0::0/0
autopkgtest [18:08:23]: test regression: -----------------------]
autopkgtest [18:08:23]: test regression: - - - - - - - - - - results - - - - - - - - - -
regression FAIL non-zero exit status 1

and to fix it:

hash:net6,port,net6: Range: Create a set: passed
hash:net6,port,net6: Range: Add zero valued element: passed
hash:net6,port,net6: Range: Test zero valued element: passed
hash:net6,port,net6: Range: Delete zero valued element: passed

by cherry-picking the upstream fix:

commit 2a66a0df03788d8a7e95972847545de0ade0dd8e
Author: Jozsef Kadlecsik <email address hidden>
Date: Fri Oct 19 19:41:26 2018 +0200

    Correct to test null valued entry in hash:net6,port,net6 test

[Rafael David Tinoco (rafaeldtinoco)]

$ git tag --contains 2a66a0df03788d8a7e95972847545de0ade0dd8e
v7.0
v7.1
v7.3
v7.4
v7.5
v7.6

Affects Bionic only.

[Rafael David Tinoco (rafaeldtinoco)]

Since this was supposed to be a SRU, but it is only a autopkgtest fix:

- patch: 2a66a0df03788d8a7e95972847545de0ade0dd8e fixes the issue

- the patch only touches the autopkgtests (not suitable for SRU)

- last time test ran was at the end of 2018 and it worked

- after that, kernel has included the following commit:

v4.19-4705-g886503f34d63 : netfilter: ipset: actually allow allowable CIDR 0 in hash:net,port,net

and the test started failing.

- forcing bad test is the best to be done and this will unblock the kmod fix:

https://launchpad.net/ubuntu/+source/kmod/24-1ubuntu3.3

[Rafael David Tinoco (rafaeldtinoco)]

Adding block-proposed-bionic so this fix can be added if there is any SRU to ipset package.

Proposed forcing bad test here:
https://code.launchpad.net/~rafaeldtinoco/britney/lp1873447/+merge/382820

[Rafael David Tinoco (rafaeldtinoco)]

https://bazaar.launchpad.net/~ubuntu-sru/britney/hints-ubuntu-bionic/revision/3173