If they are appearing in HTML export in a modal then we need to get them to appear in PDF a different way (probably appended to the page comments)
The HTML export area for comments is out of date, also which is used by the PDF also. The formatting needs to be updated.
Additional to this, adding a switch to allow private-comment-free exports.
To test this:
1. Create a page with multiple blocks
2. Make comments to the artefacts displaying in the blocks - using a combination of the 'details' view as well as adding private and public comments
3. Export the page with the 'Include comments' ON and 'Include private comments OFF'
- ✅ CHECK when 'Include comments' is OFF, 'Include private comments' switch is disabled
4. ✅ EXPECT - none of the private comments in the PDF export at the base page where the page comments sit.
6. ✅ EXPECT - the artefacts comments do not appear on the HTML export and only the PDF export
7. Export the page again with 'Include comments' ON and 'Include private comments' ON
8. ✅ EXPECT - the private comments appear in the PDF export with a grey background
The way it used to be done in html on 19.04 before placing the links in the block headers/ artefacts,
when clicking on an artefact, there was a redirection to another page with all the details of the artefact + comments
As I see it there are two options to show all details of each artefact in pdf:
1. Append details at the end of each artefact in the same page
- can have too much data, and it will change the look of the page
- need to define what happens if an artefact has too many comments, we can't show pagination
2. Append a new page to the pdf file with the details and comments of the artefact, as the html in 19.04 artefact. php
- this could be the best option since we don't have to worry about space in the original mahara page and it's easier to implement. We could use the template for /artefact/