webhooks don't fire for team-owned private webhook targets
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Colin Watson |
Bug Description
I added a git webhook on pushes to a private, team-owned repository and can't get it to fire any events on pushes. A synthetic ping event worked fine.
10:20:20 roadmr ohboy... hey so I just added a LP webhook and pushed an update to the branch in question, but the hook is not firing. Is this known/caused by the stuff you're looking into right now?
10:20:54 cjwatson roadmr: What branch please?
10:21:07 roadmr https:/
10:55:28 cjwatson roadmr: Honestly not sure. I sent a "ping" webhook delivery and it went fine. Maybe just try again?
10:56:19 roadmr cjwatson: I did and still nothing but it looks like I'm fumbling something else :) I'll keep poking
11:04:41 cjwatson Should be any branch
11:05:40 cjwatson The only thing I can think of is that there might be a problem with the repo being private
11:07:35 cjwatson Actually yes
11:08:23 cjwatson roadmr: I think there is probably a bug with team-owned private webhook targets
11:08:33 roadmr ouch
11:09:07 roadmr cjwatson: want me to file something?
11:09:14 cjwatson May have been made worse by https:/
11:09:31 cjwatson roadmr: Yeah, please file a bug. Quoting our conversation would be fine
Related branches
- William Grant (community): Approve (code)
-
Diff: 108 lines (+16/-10)3 files modifiedlib/lp/services/webapp/authorization.py (+6/-1)
lib/lp/services/webhooks/model.py (+2/-3)
lib/lp/services/webhooks/tests/test_model.py (+8/-6)
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
importance: | Undecided → High |
status: | New → In Progress |
tags: | added: lp-foundations privacy regression |
Changed in launchpad: | |
importance: | High → Critical |
Changed in launchpad: | |
status: | In Progress → Fix Committed |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |