neutron

Failing to terminate Windows processes

Bug #1872663 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Lucian Petrut

Bug Description

The neutron Windows exec call helper doesn't properly handle the situation in which the process that it's trying to kill was already terminated, in which case using WMI to fetch the process can raise an exception.

Trace: http://paste.openstack.org/raw/790116/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/719765

Changed in neutron:
assignee: nobody → Lucian Petrut (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/719765
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8fd3e884c7953645862663400af181ba233ec28f
Submitter: Zuul
Branch: master

commit 8fd3e884c7953645862663400af181ba233ec28f
Author: Lucian Petrut <email address hidden>
Date: Tue Apr 14 11:25:18 2020 +0300

    windows: fix terminating processes

    The neutron Windows exec call helper doesn't properly handle the
    situation in which the process that it's trying to kill was already
    terminated, in which case using wmi to fetch the process can raise
    an exception.

    This change ensures that those WMI exceptions will be properly
    handled.

    Closes-Bug: 1872663

    Change-Id: I00c810fe541ac5e1e9923155fe90eb07a0b4b3dd

Changed in neutron:
status: In Progress → Fix Released
Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/757050

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/757051

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/757052

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/757054

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/757055

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/757050
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=29b8d567fcb95627216f5bcc8682e5955b089e82
Submitter: Zuul
Branch: stable/ussuri

commit 29b8d567fcb95627216f5bcc8682e5955b089e82
Author: Lucian Petrut <email address hidden>
Date: Tue Apr 14 11:25:18 2020 +0300

    windows: fix terminating processes

    The neutron Windows exec call helper doesn't properly handle the
    situation in which the process that it's trying to kill was already
    terminated, in which case using wmi to fetch the process can raise
    an exception.

    This change ensures that those WMI exceptions will be properly
    handled.

    Closes-Bug: 1872663

    Change-Id: I00c810fe541ac5e1e9923155fe90eb07a0b4b3dd
    (cherry picked from commit 8fd3e884c7953645862663400af181ba233ec28f)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/stein)

Reviewed: https://review.opendev.org/757052
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9049b647b78458529c403985d4c00e4a1df53371
Submitter: Zuul
Branch: stable/stein

commit 9049b647b78458529c403985d4c00e4a1df53371
Author: Lucian Petrut <email address hidden>
Date: Tue Apr 14 11:25:18 2020 +0300

    windows: fix terminating processes

    The neutron Windows exec call helper doesn't properly handle the
    situation in which the process that it's trying to kill was already
    terminated, in which case using wmi to fetch the process can raise
    an exception.

    This change ensures that those WMI exceptions will be properly
    handled.

    Closes-Bug: 1872663

    Change-Id: I00c810fe541ac5e1e9923155fe90eb07a0b4b3dd
    (cherry picked from commit 8fd3e884c7953645862663400af181ba233ec28f)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/757051
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bcc21b306d73e206ec3473d0b847620e4c7dd024
Submitter: Zuul
Branch: stable/train

commit bcc21b306d73e206ec3473d0b847620e4c7dd024
Author: Lucian Petrut <email address hidden>
Date: Tue Apr 14 11:25:18 2020 +0300

    windows: fix terminating processes

    The neutron Windows exec call helper doesn't properly handle the
    situation in which the process that it's trying to kill was already
    terminated, in which case using wmi to fetch the process can raise
    an exception.

    This change ensures that those WMI exceptions will be properly
    handled.

    Closes-Bug: 1872663

    Change-Id: I00c810fe541ac5e1e9923155fe90eb07a0b4b3dd
    (cherry picked from commit 8fd3e884c7953645862663400af181ba233ec28f)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/queens)

Reviewed: https://review.opendev.org/757055
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1a5cb2437b7e55f2c4652ca8c6e1fc88133894d0
Submitter: Zuul
Branch: stable/queens

commit 1a5cb2437b7e55f2c4652ca8c6e1fc88133894d0
Author: Lucian Petrut <email address hidden>
Date: Tue Apr 14 11:25:18 2020 +0300

    windows: fix terminating processes

    The neutron Windows exec call helper doesn't properly handle the
    situation in which the process that it's trying to kill was already
    terminated, in which case using wmi to fetch the process can raise
    an exception.

    This change ensures that those WMI exceptions will be properly
    handled.

    Closes-Bug: 1872663

    Change-Id: I00c810fe541ac5e1e9923155fe90eb07a0b4b3dd
    (cherry picked from commit 8fd3e884c7953645862663400af181ba233ec28f)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/rocky)

Reviewed: https://review.opendev.org/757054
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6d3bf74df1d13db9ed4f49041cc4419c9202f2e9
Submitter: Zuul
Branch: stable/rocky

commit 6d3bf74df1d13db9ed4f49041cc4419c9202f2e9
Author: Lucian Petrut <email address hidden>
Date: Tue Apr 14 11:25:18 2020 +0300

    windows: fix terminating processes

    The neutron Windows exec call helper doesn't properly handle the
    situation in which the process that it's trying to kill was already
    terminated, in which case using wmi to fetch the process can raise
    an exception.

    This change ensures that those WMI exceptions will be properly
    handled.

    Closes-Bug: 1872663

    Change-Id: I00c810fe541ac5e1e9923155fe90eb07a0b4b3dd
    (cherry picked from commit 8fd3e884c7953645862663400af181ba233ec28f)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.3.1

This issue was fixed in the openstack/neutron 15.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.3.0

This issue was fixed in the openstack/neutron 16.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron queens-eol

This issue was fixed in the openstack/neutron queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron rocky-eol

This issue was fixed in the openstack/neutron rocky-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.