NetApp driver attempts to create peering between the same vservers

[Douglas Viroel]

With Manila operating in `driver_handles_share_server` true, the NetApp driver fails to create a peer relationship with the same vserver. This scenario happens when source and destination lies on the same vserver (share-server) but in different pools.
It was observed in the following scenario, but may happen with different sequence of operations:

1. Configure two NetApp backends in `driver_handles_share_server` true mode;
2. Create a share with replication enabled on availability zone 'A';
3. Create two replicas on availability zone 'B' (must be a cluster with two pools);
4. Promote one of the replicas.

When trying to creating new relationships between replicas and the new active instance, the vserver peer operation fails while creating a peering with the same vservers.

Error that appears in the log:

Apr 11 02:32:50.252616 template-devstack-xenial-1586494808 manila-share[22293]: ERROR manila.share.drivers.netapp.dataontap.cluster_mode.lib_base [None req-7e067e8b-a14d-40a1-92b5-5ac81f8a05f4 None None] Failed to change replica (4b720302-81d1-4fd9-8f67-0acd452cdab3) to a SnapMirror destination.: manila.share.drivers.netapp.dataontap.client.api.NaApiError: NetApp API failed. Reason - 18178:Cannot peer with same Vserver. The local and peer Vservers should be different.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/719674
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0d949ac485cc56a86e6a86fff7b636107cd65b9b
Submitter: Zuul
Branch: master

commit 0d949ac485cc56a86e6a86fff7b636107cd65b9b
Author: Douglas Viroel <email address hidden>
Date: Sat Apr 11 19:04:56 2020 +0000

    [NetApp] Fix vserver peer creation with same vserver

    The NetApp cDOT driver is now fixed to ignore vserver peering
    when creating and promoting shares replicas within the same
    vserver.

    Closes-Bug: #1872243
    Change-Id: I0b82c15aec7862ee3630330805ac3ac177aae127

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/719985

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/719985
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f820551c1d69112e00b49a71d0b009d21a1829ca
Submitter: Zuul
Branch: stable/train

commit f820551c1d69112e00b49a71d0b009d21a1829ca
Author: Douglas Viroel <email address hidden>
Date: Sat Apr 11 19:04:56 2020 +0000

    [NetApp] Fix vserver peer creation with same vserver

    The NetApp cDOT driver is now fixed to ignore vserver peering
    when creating and promoting shares replicas within the same
    vserver.

    Closes-Bug: #1872243
    Change-Id: I0b82c15aec7862ee3630330805ac3ac177aae127
    (cherry picked from commit 0d949ac485cc56a86e6a86fff7b636107cd65b9b)