Rewrite charm using template-python-pytest
Bug #1871782 reported by
Giuseppe Petralia
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| prometheus-grok-exporter-charm |
Fix Released
|
Medium
|
Giuseppe Petralia | ||
Bug Description
1. Refactor charm structure using pytest-template
2. Add unit tests
3. Add functional tests with zaza
4. Add http nrpe check for grok exporter.
5. Handle clean up of the unit when relations are departed.
6. Validate configuration
Related branches
~peppepetra/charm-prometheus-grok-exporter:pytest-refactor
Merged
into
charm-prometheus-grok-exporter:master
at
revision 8621e41718bc8aec8df9e3ba87bb31627ef4c579
- Jeremy Lounder (community): Approve
- Andrew McLeod: Pending requested
- Chris MacNaughton: Pending requested
-
Diff: 2054 lines (+1710/-131)30 files modified.gitignore (+25/-0)
.gitlab-ci.yml (+28/-0)
Makefile (+49/-0)
README.md (+62/-5)
config.yaml (+57/-12)
dev/null (+0/-112)
files/grok-exporter-sample.yml (+25/-0)
icon.svg (+279/-0)
interfaces/.empty (+1/-0)
layer.yaml (+7/-1)
layers/.empty (+1/-0)
lib/lib_prometheus_grok_exporter.py (+322/-0)
metadata.yaml (+5/-1)
metrics_sample.yaml (+32/-0)
reactive/prometheus_grok_exporter.py (+153/-0)
requirements.txt (+3/-0)
templates/grok-exporter.yml.j2 (+57/-0)
tests/__init__.py (+1/-0)
tests/bundles/bionic.yaml (+31/-0)
tests/bundles/focal.yaml (+31/-0)
tests/bundles/overlays/local-charm-overlay.yaml.j2 (+3/-0)
tests/bundles/xenial.yaml (+31/-0)
tests/requirements.txt (+1/-0)
tests/test_prom_grok_exporter.py (+79/-0)
tests/tests.yaml (+11/-0)
tox.ini (+65/-0)
unit_tests/conftest.py (+81/-0)
unit_tests/example.cfg (+1/-0)
unit_tests/requirements.txt (+6/-0)
unit_tests/test_lib.py (+263/-0)
| Changed in charm-prometheus-grok-exporter: | |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| milestone: | none → 20.05 |
| assignee: | nobody → Giuseppe Petralia (peppepetra86) |
| Changed in charm-prometheus-grok-exporter: | |
| status: | In Progress → Fix Committed |
| Changed in charm-prometheus-grok-exporter: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
