tripleo

tht : ApacheMaxRequestWorkers sets maxclients instead of maxrequestworkers

Bug #1871643 reported by David Hill
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Unassigned
tripleo ussuri-rc3 "tripleo ussuri-rc3"

Bug Description

tht : ApacheMaxRequestWorkers sets maxclients instead of maxrequestworkers

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

It does not, just the puppetlabs-apache module uses confusing name

https://github.com/puppetlabs/puppetlabs-apache/blob/4164befeae365225ab7b70c350f1bfb9b6a29c5b/REFERENCE.md#maxclients

Changed in tripleo:
status: New → Invalid
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

On the other hand, indeed using an alias may be suboptimal, and we probably should update it for the correct parameter https://github.com/puppetlabs/puppetlabs-apache/blob/4164befeae365225ab7b70c350f1bfb9b6a29c5b/REFERENCE.md#maxrequestworkers

Changed in tripleo:
status: Invalid → Triaged
importance: Undecided → Low
milestone: none → ussuri-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/718472

Changed in tripleo:
assignee: nobody → David Hill (david-hill-ubisoft)
status: Triaged → In Progress
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/718472
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b009c9c2395376398d4fa31d577bf447e295388f
Submitter: Zuul
Branch: master

commit b009c9c2395376398d4fa31d577bf447e295388f
Author: David Hill <email address hidden>
Date: Wed Apr 8 10:25:02 2020 -0400

    Rename ApacheMaxMaxClients property to ApacheMaxRequestWorkers

    Remove ApacheMaxMaxClients property to set apache::mod::prefork::maxclients
    and add ApacheMaxRequestWorkers to set apache::mod::prefork::maxrequestworkers
    as the current setting ApacheMaxRequestWorkers sets maxclients and this
    is confusing. This was due to maxclients being renamed to maxrequestworkers
    in the apache configuration so was legacy naming.

    Change-Id: I4e0e1beb733ae1c41d74d488481230026611c6c0
    Closes-bug: #1871643

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
Alex Schultz (alex-schultz) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in tripleo:
assignee: David Hill (david-hill-ubisoft) → nobody
tags: added: timeout-abandon
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/rocky)

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/718454
Reason: This review is > 90 days without comment, and failed Zuul the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results. For more details check policy https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.