Duplicate CSS Yaru-dark gnome-shell theme

[Mohegan]

For the Yaru-Dark theme, the gnome-shell theme's files are duplicate. In fact, the CSS files for gnome-shell can be found in /usr/share/themes/Yaru-dark/gnome-shell/ and in the gresource file (gnome-shell-theme.gresource).

1) First location :
/usr/share/themes/Yaru-dark/gnome-shell/gnome-shell.css
/usr/share/themes/Yaru-dark/gnome-shell/gnome-shell-high-contrast.css

2) Gresource file
gresource list /usr/share/gnome-shell/theme/Yaru/gnome-shell-theme.gresource | grep Yaru-dark

/org/gnome/shell/theme/Yaru-dark/gnome-shell-high-contrast.css
/org/gnome/shell/theme/Yaru-dark/gnome-shell.css

So, if you modify the /usr/share/themes/Yaru-dark/gnome-shell/gnome-shell.css (for example 2px for natural-hpadding et minimum-hpadding in #panel .panel-button), the gnome-shell theme is buggy. The modifications are only applied after mouse over the panel.

For the normal Yaru theme (not the dark), there isn't duplicate CSS file in the /usr/share/themes/Yaru/gnome-shell :
ls /usr/share/themes/Yaru/gnome-shell/*.css
/usr/share/themes/Yaru/gnome-shell/pad-osd.css

[Mohegan (jack-mohegan)]

Ubuntu version : focal beta 20.04
Package version : yaru-theme-gnome-shell 20.04.4

[Carlo Lobrano (c-lobrano)]

There must be something with the build system. The "duplicated" location is intended to support User Themes gnome extension, but

1. it should be a symlink to /usr/share/gnome-shell/theme/Yaru-dark
2. not that we use gresource, should link to... what the gresource file in /usr/share/gnome-shell/theme/Yaru?

[Mohegan (jack-mohegan)]

The both files are identicals. The both files (/usr/share/themes/Yaru-dark/gnome-shell/gnome-shell.css and /usr/share/themes/Yaru-dark/gnome-shell/gnome-shell-high-contrast.css) can be remove.

[Mohegan (jack-mohegan)]

Corrections : the files in /usr/share/themes/Yaru-dar/gnome-shell/ and in the gressource file are identical (gnome-shell.css and gnome-shell-high-contrast.css. The both files (/usr/share/themes/Yaru-dark/gnome-shell/gnome-shell.css and /usr/share/themes/Yaru-dark/gnome-shell/gnome-shell-high-contrast.css) can be remove.

[Carlo Lobrano (c-lobrano)]

In order to support User Themes gnome extension both locations are necessary.

This extension looks into `/usr/share/themes/` for alternative gnome-shell themes and makes them selectable from Gnome Tweaks.

The location `/usr/share/gnome-shell/` is used by gnome-shell itself to look for default theme.

Of course, we don't need duplicates, a symlink is good enough.

[Mohegan (jack-mohegan)]

So, it's not a bug from Yaru theme (maybe the gnome shell user theme extension is'nt perfect).

A symlink can't work. You can't make a symlink from a file in a gressource file.

[Carlo Lobrano (c-lobrano)]

I agree that using gresource a symlink does not work. It worked before the last release, where gnome-shell Yaru theme was released with assets instead than a gresource

[wontfix (wontfix)]

Upstream says this is expected behavior.

https://github.com/ubuntu/yaru/issues/2445#issuecomment-1005074036