Site not respecting the usepdfexport flag

Bug #1870993 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

With the new pdfexport option there are a few things that need to be true before it is used.

1) The chrome-php plugin needs to exist
2) The $cfg->usepdfexport setting needs to be true
3) The active setting in export_installed table needs to be true

However, it will still do the export if point 1 and 3 are true - ignoring the usepdfexport flag - if installing a new site (not upgrading)

To test (before patch):

1) checkout master
2) run make pdfexport - and also make sure any other pdfexport dependencies are met eg pdfunite
3) set config.php with: $cfg->usepdfexport = false;
3) install site
4) do an export and see pdf being built in it

So we neeed to adjust the code so that all three things are respected

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 20.04.0
milestone: 20.04.0 → 20.04rc1
Revision history for this message
Robert Lyon (robertl-9) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10846
Committed: https://git.mahara.org/mahara/mahara/commit/8c2f50f934ff38febfb6a4a7b100c7d80fd86160
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 8c2f50f934ff38febfb6a4a7b100c7d80fd86160
Author: Robert Lyon <email address hidden>
Date: Fri Apr 3 18:19:53 2020 +1300

Bug 1870993: Respect $cfg->usepdfexport value

If all other dependencies are met then it is possible to export by pdf
on new installs without $cfg->usepdfexport set

Change-Id: I7a61e88ba835609564f1aaeaa46be89b82bd8974
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10888

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10888
Committed: https://git.mahara.org/mahara/mahara/commit/f73d7864f7e7e234a11d42d60d18ec070bdbaa49
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit f73d7864f7e7e234a11d42d60d18ec070bdbaa49
Author: Robert Lyon <email address hidden>
Date: Fri Apr 3 18:19:53 2020 +1300

Bug 1870993: Respect $cfg->usepdfexport value

If all other dependencies are met then it is possible to export by pdf
on new installs without $cfg->usepdfexport set

Change-Id: I7a61e88ba835609564f1aaeaa46be89b82bd8974
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 8c2f50f934ff38febfb6a4a7b100c7d80fd86160)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04rc1 → 20.04.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.