Site not respecting the usepdfexport flag
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon |
Bug Description
With the new pdfexport option there are a few things that need to be true before it is used.
1) The chrome-php plugin needs to exist
2) The $cfg->usepdfexport setting needs to be true
3) The active setting in export_installed table needs to be true
However, it will still do the export if point 1 and 3 are true - ignoring the usepdfexport flag - if installing a new site (not upgrading)
To test (before patch):
1) checkout master
2) run make pdfexport - and also make sure any other pdfexport dependencies are met eg pdfunite
3) set config.php with: $cfg->usepdfexport = false;
3) install site
4) do an export and see pdf being built in it
So we neeed to adjust the code so that all three things are respected
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Robert Lyon (robertl-9) |
milestone: | none → 20.04.0 |
milestone: | 20.04.0 → 20.04rc1 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
milestone: | 20.04rc1 → 20.04.0 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
https:/ /reviews. mahara. org/#/c/ 10846/