default backup path folder not initialized with wallet folder

[Jeff Fortin Tam]

Running Homebank 5.3.1 on Fedora 31.

I noticed that BackupPath defaults to the user's home directory. This is a little bit weird because I would either expect the backup files to be in same directory as the files they are backuping, or in a dedicated backup folder. Otherwise, if your main xhb files are not in the root of the home directory, it's a bit weird to have a bunch of .bak files laying around in plain sight.

If having the backup files in the same directory of the file they are backuping is not desirable, I'm thinking the XDG "shared data" folder (which would be, typically, ~/.local/share/homebank/backups/) might be more appropriate than "~" ? See also https://specifications.freedesktop.org/basedir-spec/latest/ (but as far as I can tell, Homebank already uses the XDG config directory for its preferences files, so I presume you know about the XDG user directories spec).

[Maxime DOYEN (mdoyen)]

The default backup folder is in fact the same than the default wallet folder.

I simply introduced a different path in 5.3 with #1847645, and forgot to initialize it with the wallet folder path that existing old user maybe have changed.

[Maxime DOYEN (mdoyen)]

I did fix the initialisation of backup folder for users < 5.3, it will copy the wallet folder, so that we keep the old behavior