sstream-mirror max options doesn't work with filtering for versions

[Gábor Mészáros]

On eoan:
ubuntu@eoan:~$ apt list --installed simplestreams
Listing... Done
simplestreams/eoan,now 0.1.0-25-gba75825b-0ubuntu1 all [installed]
ubuntu@eoan:~$ sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version~(2.4|2.6)' --dry-run
+ com.ubuntu.juju:16.04:amd64 20190503 2.6-rc2-xenial-amd64 agent/2.6-rc2/juju-2.6-rc2-ubuntu-amd64.tgz 28 Mb
+ com.ubuntu.juju:18.04:amd64 20190503 2.6-rc2-bionic-amd64 agent/2.6-rc2/juju-2.6-rc2-ubuntu-amd64.tgz 28 Mb
+ com.ubuntu.juju:16.04:amd64 20191029 2.6.10-xenial-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb
+ com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb
+ com.ubuntu.juju:16.04:amd64 20191029 2.6.10-xenial-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb
+ com.ubuntu.juju:18.04:amd64 20191029 2.6.10-bionic-amd64 agent/2.6.10/juju-2.6.10-ubuntu-amd64.tgz 29 Mb
174 Mb change

On bionic:
root@iptv-receiver:~# apt list --installed simplestreams
Listing... Done
simplestreams/bionic,now 0.1.0-490-g3cc8988-0ubuntu1~ubuntu18.04.1 all [installed]
N: There are 2 additional versions. Please use the '-a' switch to see them.
root@bionic:~# sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version
~(2.4|2.6)' --dry-run
0 Mb change
Same thing with the non-dev version (from bionic-updates):
root@bionic:~# apt list --installed simplestreams
Listing... Done
simplestreams/bionic-updates,now 0.1.0~bzr460-0ubuntu1.1 all [installed,upgradable to: 0.1.0-490-g3cc8988-0ubuntu1~ubuntu18.04.1]
N: There is 1 additional version. Please use the '-a' switch to see it
root@bionic:~# sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version
~(2.4|2.6)' --dry-run
0 Mb change

[Christian Ehrhardt  (paelzer)]

Hi,
I come by trying to close or revive dormant bugs.
I can confirm what you report and it seems that it works in all latter releases.

But interestingly I also found that even using a newer version in Bionic (like from backports) won't help:

$ apt install simplestreams=0.1.0-48-gb936edd4-0ubuntu1~bpo18.04.1
...
$ sstream-mirror --no-verify --max=1 --progress --path=streams/v1/index2.sjson https://streams.canonical.com/juju/tools ./ arch=amd64 'release~(xenial|bionic)' 'version ~(2.4|2.6)' --dry-run
0 Mb change

Still filters out all of them.

And BTW in case anyone wonders, without --max being set we get many results

...
+ com.ubuntu.juju:18.04:amd64 20180725 2.4.1-bionic-amd64 agent/2.4.1/juju-2.4.1-ubuntu-amd64.tgz 21 Mb
+ com.ubuntu.juju:18.04:amd64 20180703 2.4.0-bionic-amd64 agent/2.4.0/juju-2.4.0-ubuntu-amd64.tgz 21 Mb
890 Mb change

I'm wondering if simplestreams might be affected, but the issue being in another python component.

In any case, to act further this would need a debugging session where/why the filtering on Bionic looses that.

[Christian Ehrhardt  (paelzer)]

Tagged "bitesize" for the debugging work, depending on what is found there this might be a completely different picture.

[Michał Małoszewski (michal-maloszewski99)]

Take care of that one.

[Michał Małoszewski (michal-maloszewski99)]

https://bugs.launchpad.net/ubuntu/+source/simplestreams/+bug/2019864 needs to be fixed first
Bionic reaches EOSS in June 2023

[Michał Małoszewski (michal-maloszewski99)]

This bug seems to not be a "bitesize". It would need more investigation (there may be more patches needed to actually get that fix), because the https://git.launchpad.net/simplestreams/commit/?id=21782a0d0b45b13dca1d712a1c889b68cdb1e4f5 does not fix that bug. I was trying to find a commit that would fix that, but none of them were suitable. Moreover, I compared the source code in Focal (where it works) and Bionic and moreover, Eoan and the files after applying the commit: 21782a0d0b45b13dca1d712a1c889b68cdb1e4f5 to Bionic were binary equal - what is interesting. Since Bionic reaches EOSS in June 2023 and it's a low priority bug, I am going to unassign myself, remove the server-todo tag and close that bug.