Update on train fail on compute node on malformed block in Compute/update_tasks.yaml

Bug #1870206 reported by Sofer Athlan-Guyot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Sofer Athlan-Guyot

Bug Description

Hi,

originally reported there https://bugzilla.redhat.com/show_bug.cgi?id=1819085

Hi, overcloud update run for the compute group fails with:

2020-03-26 05:38:59 | TASK [include_tasks] ***********************************************************
2020-03-26 05:38:59 | Thursday 26 March 2020 05:38:57 +0000 (0:00:00.185) 0:00:30.227 ********
2020-03-26 05:38:59 | fatal: [compute-0]: FAILED! => {"reason": "A malformed block was encountered while loading a block\n\nThe error appears to be in '/var/lib/mistral/4a5aae95-729d-493b-8932-1dc494624eee/Compute/update_tasks.yaml': line 35, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: step|int == 3\n- block:\n ^ here\n"}
2020-03-26 05:38:59 | fatal: [compute-1]: FAILED! => {"reason": "A malformed block was encountered while loading a block\n\nThe error appears to be in '/var/lib/mistral/4a5aae95-729d-493b-8932-1dc494624eee/Compute/update_tasks.yaml': line 35, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: step|int == 3\n- block:\n ^ here\n"}
2020-03-26 05:38:59 |
2020-03-26 05:38:59 | PLAY RECAP *********************************************************************
2020-03-26 05:38:59 | compute-0 : ok=16 changed=3 unreachable=0 failed=1 skipped=5 rescued=0 ignored=0
2020-03-26 05:38:59 | compute-1 : ok=15 changed=3 unreachable=0 failed=1 skipped=5 rescued=0 ignored=0

The tht version is updated to:

openstack-tripleo-heat-templates.noarch 11.3.2-0.20200324120625.c3a8eb4.el8ost @rhelosp-16.0

The block created is indeed faulty:

- block:
    include_role:
      name: tripleo-systemd-wrapper
    loop:
    - cmd: $(if [ -f /usr/sbin/haproxy-systemd-wrapper ]; then echo "/usr/sbin/haproxy
        -Ds"; else echo "/usr/sbin/haproxy -Ws"; fi)
      kill_script: haproxy-kill
      name: ovn_metadata_haproxy
    loop_control:
      loop_var: ovn_wrapper_item
    name: set conditions
    set_fact:
      debug_enabled: true
      haproxy_wrapper_enabled: true
    vars:
      tripleo_systemd_wrapper_cmd: '{{ ovn_wrapper_item.cmd }}'
      tripleo_systemd_wrapper_config_bind_mount: /var/lib/config-data/puppet-generated/neutron:/etc/neutron:ro
      tripleo_systemd_wrapper_container_cli: '{{ container_cli }}'
      tripleo_systemd_wrapper_debug: '{{ debug_enabled }}'
      tripleo_systemd_wrapper_docker_additional_sockets:
      - /var/lib/openstack/docker.sock
      tripleo_systemd_wrapper_image_name: undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp16-openstack-neutron-metadata-agent-ovn:20200324.1
      tripleo_systemd_wrapper_service_dir: /var/lib/neutron
      tripleo_systemd_wrapper_service_kill_script: '{{ ovn_wrapper_item.kill_script
        }}'
      tripleo_systemd_wrapper_service_name: '{{ ovn_wrapper_item.name }}'
  when: step|int == 1

relative to Ia898cb8b1c888aca45ba58ab99e61885a1da4f4e this is unexpected.

Changed in tripleo:
assignee: nobody → Sofer Athlan-Guyot (sofer-athlan-guyot)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/716700

wes hayutin (weshayutin)
Changed in tripleo:
status: Confirmed → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/716700
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0ce1716140e56ec03324705ef8d7a7b92387784d
Submitter: Zuul
Branch: stable/train

commit 0ce1716140e56ec03324705ef8d7a7b92387784d
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Apr 1 20:05:53 2020 +0200

    [TRAIN-ONLY] Fix systemd-wrapper integration during update.

    The anchor need to be attached directly to the entry for the reference
    to render properly the yaml task file.

    This is train only because the associated anchor is only created in
    this openstack version as it was required for the transition during
    update.

    Change-Id: I1c2624061aee9f56ef857cf88aa0954ad27f9758
    Closes-Bug: #1870206

tags: added: in-stable-train
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Changed in tripleo:
milestone: victoria-1 → victoria-3
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

Revision history for this message
Marios Andreou (marios-b) wrote :

Bug status has been set to 'Fix-Released' based on the discussion and/or patches above. If you disagree please re-set 'Triaged' and reach out to us on freenode #tripleo thank you!

Changed in tripleo:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.