upgradeStepsSuite.TestWriteUniterState intermittent failure

[Ian Booth]

https://jenkins.juju.canonical.com/job/github-make-check-juju/4753/consoleFull

16:33:44 FAIL: upgradesteps_test.go:56: upgradeStepsSuite.TestWriteUniterState
16:33:44
16:33:44 upgradesteps_test.go:70:
16:33:44 err := client.WriteUniterState(
16:33:44 map[names.Tag]string{
16:33:44 uTag0: str0,
16:33:44 uTag1: str1,
16:33:44 },
16:33:44 )
16:33:44 upgradesteps_test.go:149:
16:33:44 m.c.Assert(obtained.Args, jc.DeepEquals, m.expected.Args)
16:33:44 ... obtained []params.SetUnitStateArg = []params.SetUnitStateArg{params.SetUnitStateArg{Tag:"unit-test-1", State:(*map[string]string)(nil), UniterState:(*string)(0xc0000a32b0), RelationState:(*map[int]string)(nil), StorageState:(*string)(nil)}, params.SetUnitStateArg{Tag:"unit-test-0", State:(*map[string]string)(nil), UniterState:(*string)(0xc0000a32c0), RelationState:(*map[int]string)(nil), StorageState:(*string)(nil)}}
16:33:44 ... expected []params.SetUnitStateArg = []params.SetUnitStateArg{params.SetUnitStateArg{Tag:"unit-test-0", State:(*map[string]string)(nil), UniterState:(*string)(0xc0000a3210), RelationState:(*map[int]string)(nil), StorageState:(*string)(nil)}, params.SetUnitStateArg{Tag:"unit-test-1", State:(*map[string]string)(nil), UniterState:(*string)(0xc0000a3230), RelationState:(*map[int]string)(nil), StorageState:(*string)(nil)}}
16:33:44 ... mismatch at [0].Tag: unequal; obtained "unit-test-1"; expected "unit-test-0"
16:33:44
16:33:44 upgradesteps_test.go:70:
16:33:44 err := client.WriteUniterState(
16:33:44 map[names.Tag]string{
16:33:44 uTag0: str0,
16:33:44 uTag1: str1,
16:33:44 },
16:33:44 )
16:33:44 /home/ubuntu/go/src/github.com/juju/juju/vendor/github.com/golang/mock/gomock/controller.go:252:
16:33:44 ctrl.T.Errorf("missing call(s) to %v", call)
16:33:44 ... Error: missing call(s) to *mocks.MockFacadeCaller.FacadeCall(is equal to WriteUniterState, Match the contents of the UniterState pointer in params.SetUnitStateArg, is anything) /home/ubuntu/go/src/github.com/juju/juju/api/upgradesteps/upgradesteps_test.go:124
16:33:44
16:33:44 upgradesteps_test.go:70:
16:33:44 err := client.WriteUniterState(
16:33:44 map[names.Tag]string{
16:33:44 uTag0: str0,
16:33:44 uTag1: str1,
16:33:44 },
16:33:44 )
16:33:44 /home/ubuntu/go/src/github.com/juju/juju/vendor/github.com/golang/mock/gomock/controller.go:255:
16:33:44 ctrl.T.Fatalf("aborting test due to missing call(s)")
16:33:44 ... Error: aborting test due to missing call(s)