Postgresql periodic job failing every day

[Slawek Kaplonski]

Periodic job "neutron-tempest-postgres-full" is failing every day since 18.03.2020.
Always same tests are red:
tempest.api.network.test_networks.NetworksIpV6TestAttrs.test_create_delete_slaac_subnet_with_ports
tempest.api.network.test_networks.NetworksIpV6TestAttrs.test_create_delete_stateless_subnet_with_ports

Errors like https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_95c/periodic/opendev.org/openstack/neutron/master/neutron-tempest-postgres-full/95cb0e8/testr_results.html

It may be that https://review.opendev.org/#/c/709444/ is culprit of that issue but we need to verify that.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/715011

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/715075

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/715153

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715011
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=79e8230e39c5ba30ace3afe3d9f1cc15463ea9ad
Submitter: Zuul
Branch: master

commit 79e8230e39c5ba30ace3afe3d9f1cc15463ea9ad
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Mar 25 17:35:15 2020 +0000

    Filter subnet by segment ID or None

    In "_query_filter_by_fixed_ips_segment", the subnet query should be
    filtered by segment ID if exists, or None otherwise.

    The "segment_id" field (from the "subnet" DB register) is a string.
    As reported in the related bug, PostgreSQL does not accept to compare
    this field with a boolean value ("false"). This patch avoids the
    previous situation where the DB WHERE statement was trying to compare
    a string and a boolean:

      operator does not exist: character varying = boolean
      LINE 5: WHERE anon_1.subnets_segment_id = false
      No operator matches the given name and argument type(s). You might \
        need to add explicit type casts.

    Change-Id: I1ff29eb45c6663885c2b8a126a3669e75b920c98
    Closes-Bug: #1869034

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.opendev.org/715075

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715153
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=56cf98d52ef6f1958951d91f8579ed5719792bdc
Submitter: Zuul
Branch: stable/train

commit 56cf98d52ef6f1958951d91f8579ed5719792bdc
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Mar 25 17:35:15 2020 +0000

    Filter subnet by segment ID or None

    In "_query_filter_by_fixed_ips_segment", the subnet query should be
    filtered by segment ID if exists, or None otherwise.

    The "segment_id" field (from the "subnet" DB register) is a string.
    As reported in the related bug, PostgreSQL does not accept to compare
    this field with a boolean value ("false"). This patch avoids the
    previous situation where the DB WHERE statement was trying to compare
    a string and a boolean:

      operator does not exist: character varying = boolean
      LINE 5: WHERE anon_1.subnets_segment_id = false
      No operator matches the given name and argument type(s). You might \
        need to add explicit type casts.

    Change-Id: I1ff29eb45c6663885c2b8a126a3669e75b920c98
    Closes-Bug: #1869034
    (cherry picked from commit 79e8230e39c5ba30ace3afe3d9f1cc15463ea9ad)