ExtraHostFileEntries only works for -ONE- entry, not more than one

Bug #1868588 reported by Cédric Jeanneret
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Incomplete
Medium
Harald Jensås

Bug Description

(Discovered on Red Hat BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1815218)

Basically, when we pass a list of entries in ExtraHostFileEntries, it get written as a single, one-liner in the /etc/hosts file.

This is a regression due to the introduction of tripleo_ansible "tripleo_hosts_entries" role.

The following patch corrects the issue:
https://review.opendev.org/714409

Thank you Harald for your proposal!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-ansible (master)

Change abandoned by Harald Jensås (<email address hidden>) on branch: master
Review: https://review.opendev.org/714409
Reason: Based on the discussion related to scaling with ansible inventory spec. Let's pick up https://review.opendev.org/714041 again instead.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Bogdan Dobrelya (bogdando) (<email address hidden>) on branch: master
Review: https://review.opendev.org/714611

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/715357

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/715357
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=f15182e589534af5bc6301c6b3471b35c7701285
Submitter: Zuul
Branch: stable/train

commit f15182e589534af5bc6301c6b3471b35c7701285
Author: Cédric Jeanneret <email address hidden>
Date: Fri Mar 20 08:22:11 2020 +0100

    Rework how we push the content in the file

    Since we allow to pass lists, we can't just use |join('').

    In addition, using the multi-line support in YAML via the "|" creates
    some issues when we want to use |join('\n'): it gets escaped, meaning we
    end with a one-line content with some \n entries.

    The present patch ensures that:
    - generated content is still pushed in a fact to not lose time
    - static content (lists) is properly treated and outputs correctly

    Closes-Bug: #1868588
    Change-Id: I7e520035f24503e59840b34e5b2d9e9966cd6ca4
    (cherry picked from commit 75ed35c46a3368c19ff7aa14c13609fdf7008255)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 0.5.0

This issue was fixed in the openstack/tripleo-ansible 0.5.0 release.

wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Changed in tripleo:
milestone: victoria-1 → victoria-3
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Revision history for this message
Marios Andreou (marios-b) wrote :

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo

Changed in tripleo:
milestone: xena-1 → none
status: In Progress → Incomplete
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.