'openstack tripleo valiador run' fails with TypeError

Bug #1868416 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Rabi Mishra

Bug Description

Steps to reproduce:

[stack@osp-df-2 ~]$ . stackrc
(undercloud) [stack@osp-df-2 ~]$openstack tripleo validator run --group "pre-deployment"
START with options: --debug tripleo validator run --group pre-deployment
options: Namespace(access_token='***', access_token_endpoint='', access_token_type='', aodh_endpoint='', application_credential_id='', application_credential_name='', application_credential_secret='***', auth_methods='', auth_type='password', auth_url='https://192.168.24.2:13000', cacert='/etc/pki/ca-trust/source/anchors/cm-local-ca.pem', cert='', client_id='', client_secret='***', cloud='', code='', debug=True, default_domain='default', default_domain_id='', default_domain_name='', deferred_help=False, discovery_endpoint='', domain_id='', domain_name='', endpoint='', identity_provider='', identity_provider_url='', insecure=None, inspector_api_version='1', inspector_url=None, interface='public', key='', log_file=None, openid_scope='', os_alarming_api_version='2', os_baremetal_api_version='1.58', os_beta_command=False, os_compute_api_version='', os_container_infra_api_version='1', os_data_processing_api_version='1.1', os_data_processing_url='', os_database_api_version='1', os_dns_api_version='2', os_event_api_version='2', os_identity_api_version='3', os_image_api_version='', os_key_manager_api_version='1', os_loadbalancer_api_version='2.0', os_metrics_api_version='1', os_network_api_version='', os_object_api_version='', os_orchestration_api_version='1', os_project_id=None, os_project_name=None, os_queues_api_version='2', os_share_api_version='2.51', os_tripleoclient_api_version='2', os_volume_api_version='', os_workflow_api_version='2', passcode='', password='***', profile='', project_domain_id='', project_domain_name='Default', project_id='', project_name='admin', protocol='', redirect_uri='', region_name='', remote_project_domain_id='', remote_project_domain_name='', remote_project_id='', remote_project_name='', roles='', service_provider='', service_provider_endpoint='', service_provider_entity_id='', system_scope='', timing=False, token='***', trust_id='', user='', user_domain_id='', user_domain_name='Default', user_id='', username='admin', verbose_level=3, verify=None)

<snip>isinstance() arg 2 must be a type or tuple of types
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/cliff/app.py", line 399, in run_subcommand
    parsed_args = cmd_parser.parse_args(sub_argv)
  File "/usr/lib64/python3.6/argparse.py", line 1734, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/usr/lib64/python3.6/argparse.py", line 1766, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib64/python3.6/argparse.py", line 1972, in _parse_known_args
    start_index = consume_optional(start_index)
  File "/usr/lib64/python3.6/argparse.py", line 1912, in consume_optional
    take_action(action, args, option_string)
  File "/usr/lib64/python3.6/argparse.py", line 1840, in take_action
    action(self, namespace, argument_values, option_string)
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/tripleo_validator.py", line 47, in __call__
    opts = oooutils.get_validation_group_name_list()
  File "/usr/lib/python3.6/site-packages/tripleoclient/utils.py", line 2172, in get_validation_group_name_list
    if groups and isinstance(dict, groups):
TypeError: isinstance() arg 2 must be a type or tuple of types
clean_up TripleOValidatorRun: isinstance() arg 2 must be a type or tuple of types
END return value: 1

Looks like a regression from https://review.opendev.org/#/c/704521 as the order of parameter to isinstance() is incorrect.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/714279

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/714279
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=e7693eb1aef49f027b0305ccee8253e235e78abb
Submitter: Zuul
Branch: master

commit e7693eb1aef49f027b0305ccee8253e235e78abb
Author: Rabi Mishra <email address hidden>
Date: Sun Mar 22 08:21:34 2020 +0530

    Fix order of parameters to isinstance()

    Regression from https://review.opendev.org/704521

    Change-Id: Iadcfcd97e5f3d65de4179a706bc30f9c5e3aae41
    Closes-Bug: #1868416

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.2.0

This issue was fixed in the openstack/python-tripleoclient 13.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.