Missing update tasks for Neutron wrapper transition to Ansible

[Emilien Macchi]

The tasks that converge the Neutron wrappers from Puppet to Ansible are handled by deploy_step_tasks but not update_tasks; so during a minor update we are missing these steps and the containers fail in paunch during the converge step:

ERROR paunch [ ] /var/lib/neutron/l3_keepalived/wrapper is not a valid volume source
ERROR paunch [ ] /var/lib/neutron/l3_haproxy/wrapper is not a valid volume source
ERROR paunch [ ] /var/lib/neutron/l3_dibbler/wrapper is not a valid volume source
ERROR paunch [ ] The following containers failed validations and were not started: neutron_dhcp, neutron_l3_agent

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/712200

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/712200
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5108054aac7eb45533073cff08f0e82db3ac355f
Submitter: Zuul
Branch: stable/train

commit 5108054aac7eb45533073cff08f0e82db3ac355f
Author: Alex Schultz <email address hidden>
Date: Tue Mar 10 16:48:36 2020 -0600

    [TRAIN-ONLY] Add systemd-wrapper update tasks

    We backported the conversion for the side car containers wrapper tasks
    from puppet to ansible in https://review.opendev.org/#/c/706381/.
    However during a minor update, the deploy step tasks would be run after
    the moutnts have been updated. We need to duplicate the deploy step
    tasks for the wrapper creation so the mounts exist during the 'overcloud
    update run process' as this runs before the 'overcloud update
    converge'.

    Change-Id: Ia898cb8b1c888aca45ba58ab99e61885a1da4f4e
    Closes-Bug: #1866922

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

[Marios Andreou (marios-b)]

Bug status has been set to 'Fix-Released' based on the discussion and/or patches above. If you disagree please re-set 'Triaged' and reach out to us on freenode #tripleo thank you!