Mahara

Auth SAML get disco list issue

Bug #1866773 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 20.04.0

Bug Description

[WAR] 16 (auth/saml/lib.php:719) count(): Parameter must be an array or an object that implements Countable

We are returning 0 if there are no disco lists and then try to do a count on them which is not correct.

We should return an empty array and use count on that

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10818

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10818
Committed: https://git.mahara.org/mahara/mahara/commit/214d7db684f9acac90b784362c93e1e9a13e94a2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 214d7db684f9acac90b784362c93e1e9a13e94a2
Author: Robert Lyon <email address hidden>
Date: Tue Mar 10 20:45:30 2020 +1300

Bug 1866773: Count array instead of integer

Change-Id: Ifed601c60ff953577f01dc01e335accc87646414
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: New → Fix Committed
milestone: none → 20.04.1
milestone: 20.04.1 → 20.04.0
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10918

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10918
Committed: https://git.mahara.org/mahara/mahara/commit/7fe7ff55e23996cbbe7734aedaf2db6b2d47d00b
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 7fe7ff55e23996cbbe7734aedaf2db6b2d47d00b
Author: Robert Lyon <email address hidden>
Date: Tue Mar 10 20:45:30 2020 +1300

Bug 1866773: Count array instead of integer

Change-Id: Ifed601c60ff953577f01dc01e335accc87646414
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 214d7db684f9acac90b784362c93e1e9a13e94a2)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.