using an environment file from the current working directory no longer works for overcloud deploy

[Alex Schultz]

We appear to no longer copying the files when they aren't in the THT path into the temporary THT path.

export THT=/usr/share/openstack-tripleo-heat-templates
openstack overcloud deploy --templates $THT/ --timeout 100 -e $THT/environments/enable-swap.yaml -e $THT/environments/disable-telemetry.yaml -e container-image-prepare.yaml -e params.ya

This results in:
Removing the current plan files
Uploading new plan files
Temporary Swift GET/PUT URL parameters have successfully been updated.
Plan updated.
Processing templates in the directory /tmp/tripleoclient-YhvmZA/tripleo-heat-templates
Exception occured while running the command
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/tripleoclient/command.py", line 34, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 187, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 936, in take_action
    self._deploy_tripleo_heat_templates_tmpdir(stack, parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 363, in _deploy_tripleo_heat_templates_tmpdir
    new_tht_root, tht_root)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 433, in _deploy_tripleo_heat_templates
    cleanup=(not parsed_args.no_cleanup))
  File "/usr/lib/python2.7/site-packages/tripleoclient/utils.py", line 1524, in process_multiple_environments
    env_path=env_path)
  File "/usr/lib/python2.7/site-packages/heatclient/common/template_utils.py", line 312, in process_environment_and_files
    raw_env = request.urlopen(env_url).read()
  File "/usr/lib64/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib64/python2.7/urllib2.py", line 431, in open
    response = self._open(req, data)
  File "/usr/lib64/python2.7/urllib2.py", line 449, in _open
    '_open', req)
  File "/usr/lib64/python2.7/urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "/usr/lib64/python2.7/urllib2.py", line 1353, in file_open
    return self.open_local_file(req)
  File "/usr/lib64/python2.7/urllib2.py", line 1393, in open_local_file
    raise URLError(msg)
URLError: <urlopen error [Errno 2] No such file or directory: '/tmp/tripleoclient-YhvmZA/container-image-prepare.yaml'>
<urlopen error [Errno 2] No such file or directory: '/tmp/tripleoclient-YhvmZA/container-image-prepare.yaml'>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/711556

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/711556
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=bf2e56b1407699a3963354929f7648e391581831
Submitter: Zuul
Branch: master

commit bf2e56b1407699a3963354929f7648e391581831
Author: Alex Schultz <email address hidden>
Date: Thu Mar 5 14:17:25 2020 -0700

    Partial Revert "Replace ansible shell with python runner"

    This is a partial revert of bcc9c667471e832739c20ae06b8325ef95a5e56b.
    The change broke using non-fully qualified paths for the overcloud
    deploy command. This puts the code back that fixes using a local
    environment file during the deployment.

    Change-Id: Ia0fc3ef70a1f3938ccccfd778cec24628bbee1fe
    Closes-Bug: #1866249

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 13.2.0 release.