[UBUNTU 20.04] ZPCI used write back addresses by default but should use write through

Bug #1866162 reported by bugproxy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
Undecided
Frank Heimes
linux (Ubuntu)
Fix Released
Undecided
Frank Heimes

Bug Description

In the initial MIO support introduced in

commit 71ba41c9b1d9 ("s390/pci: provide support for MIO instructions")

setting up the PCI BAR resources defaults to using the
mio_wb address as the resource's start address.

This means users of the mapping, which includes most drivers, will get write combining on PCI Stores.

his may lead to problems when drivers expect write through
behavior when not using an explicit ioremap_wc() which is the default
behavior on other platforms.

The attached patch changes the default to write through.
It has already been reviewed and is currently queued to be send for
Linux 5.6-rc5 with a CC stable tag.

Revision history for this message
bugproxy (bugproxy) wrote : s390/pci: Fix unexpected write combine on resource

Default Comment by Bridge

tags: added: architecture-s39064 bugnameltc-184193 severity-high targetmilestone-inin2004
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → linux (Ubuntu)
bugproxy (bugproxy)
tags: added: severity-critical
removed: severity-high
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: New → Triaged
Changed in linux (Ubuntu):
status: New → Triaged
assignee: Skipper Bug Screeners (skipper-screen-team) → Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
assignee: nobody → Frank Heimes (fheimes)
Revision history for this message
Frank Heimes (fheimes) wrote :

Patch request submitted:
https://lists.ubuntu.com/archives/kernel-team/2020-March/thread.html#108082
changing status to 'In Progress'.

Changed in linux (Ubuntu):
status: Triaged → In Progress
Changed in ubuntu-z-systems:
status: Triaged → In Progress
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2020-03-09 04:15 EDT-------
This has now been merged in Linus' upstream tree as

df057c914a9c219ac8b8ed22caf7da2f80c1fe26 s390/pci: Fix unexpected write combine on resource

Revision history for this message
Frank Heimes (fheimes) wrote :

Hi Niklas, yes, thx.
Also found the patch in 'linux-next' and cherry-picked that one.

Revision history for this message
Frank Heimes (fheimes) wrote :

Fix released via stable linux 5.4.25 update

Changed in linux (Ubuntu):
status: In Progress → Fix Released
Changed in ubuntu-z-systems:
status: In Progress → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2020-03-17 04:16 EDT-------
IBM Bugzilla status -> closed, Fix Released with focal

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.