pyghmi seems to have broken virtualbmc since yesterday

Bug #1865987 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pyghmi
Fix Released
Undecided
Jarrod Johnson

Bug Description

Our CI jobs are failing since yesterday night with the following:
Mar 04 06:43:59 undercloud-0 python[83170]: 2020-03-04 06:43:59,320.320 589792 INFO VirtualBMC [-] Shutdown vBMC for domain messaging-0, cause 'ServerSession' object has no attribute 'rqlun'

Seems to me that https://opendev.org/x/pyghmi/commit/a3001d87a73ef9343627a42c92d54d5eb0dc49a2 is relevant in this context.

Revision history for this message
Michele Baldessari (michele) wrote :

tested pyghmi 1.5.10 and it works correctly

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to pyghmi (master)

Fix proposed to branch: master
Review: https://review.opendev.org/711226

Changed in pyghmi:
assignee: nobody → Dmitry Tantsur (divius)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on pyghmi (master)

Change abandoned by Dmitry Tantsur (<email address hidden>) on branch: master
Review: https://review.opendev.org/711226
Reason: Gotcha, will check that one

Changed in pyghmi:
assignee: Dmitry Tantsur (divius) → Jarrod Johnson (jbjohnso)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pyghmi (master)

Reviewed: https://review.opendev.org/711228
Committed: https://git.openstack.org/cgit/x/pyghmi/commit/?id=51ab5ca823b6d15ebaf3b9d405698259fdcfbcfe
Submitter: Zuul
Branch: master

commit 51ab5ca823b6d15ebaf3b9d405698259fdcfbcfe
Author: Jarrod Johnson <email address hidden>
Date: Wed Mar 4 08:35:03 2020 -0500

    Fix server session to properly support rqlun

    Honor rqlun from client, if not zero. There are BMC implementations
    that fail to follow the spec and do rqlun of zero, but pyghmi
    implements it correctly. In practice I have never seen an
    rqlun of non-zero except as an experiment.

    Closes-Bug: #1865987

    Change-Id: I73e59672ce5e146cf24386c2228fa8dae3bc579c

Changed in pyghmi:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.