when using mahara.php json_reply() function we are not able to return data on error

[Robert Lyon]

When using the pieform.php version of json_reply() we can get error message in js when returning error - but with mahara.php we just return error but can't access the message in js

We need to adjust this so that we can get the error returned/displayed in a js way

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10784

[Robert Lyon (robertl-9)]

To test:

1) Edit your 'dashboard' page and add the 'My friends' block
2) Add another block to the page and try and select 'My friends' - you can't and it's not obvious why
3) Try and add a 'My portfolios' block - same problem

The reason is both these block can only be on page once but unless you are adding your new block to the top of the page you probably not get to see the error message there.

We need to error message to appear also in the config modal as well

Also the error shows the blocktype name of the block rather than the display name of the block, eg 'myviews' instead of 'My portfolios' so that will need fixing also

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10784
Committed: https://git.mahara.org/mahara/mahara/commit/154c2894ea59551b296cc4ba5d361fa9750a91bd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 154c2894ea59551b296cc4ba5d361fa9750a91bd
Author: Robert Lyon <email address hidden>
Date: Fri Feb 28 11:59:49 2020 +1300

Bug 1865095: Config modal error message display

We need to be able to display the error when the json_reply() used is
the mahara.php one and not the pieform.php one - for non form related
error replies

Change-Id: I9a1407fc484afc8ef1aef69a2ce01f592c2c6ee7
Signed-off-by: Robert Lyon <email address hidden>