charm-logrotate cron job created with wrong access permissions
Bug #1864599 reported by
Paul Goins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| logrotate-charm |
Fix Released
|
Medium
|
Ashley James | ||
Bug Description
The code intends to create the charm-logrotate job with chmod 700, however, it uses os.chmod for this, and to do the right thing the code needs to use the constant 0o700 rather than 700. The integer 700 translates to octal 1274, which is totally different.
Related branches
~dashmage/charm-logrotated:bug/2017798-update-cron-daily-location
- JamesLin: Approve
- 🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration)
- Chi Wai CHAN: Needs Information
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
- BootStack Reviewers: Pending requested
- Robert Gildein: Pending requested
- Tianqi Xiao: Pending requested
-
Diff: 201 lines (+70/-25)4 files modifiedsrc/lib/lib_cron.py (+16/-14)
src/tests/functional/requirements.txt (+1/-0)
src/tests/functional/test_logrotate.py (+13/-5)
src/tests/unit/test_logrotate.py (+40/-6)
| Changed in charm-logrotated: | |
| importance: | Undecided → Medium |
| tags: | added: good-first-bug |
| tags: | added: bseng-1217 |
Revision history for this message
| Ashley James (dashmage) wrote | #1 |
| Changed in charm-logrotated: | |
| status: | New → Fix Committed |
| assignee: | nobody → Ashley James (dashmage) |
| Changed in charm-logrotated: | |
| milestone: | none → 23.07 |
| Changed in charm-logrotated: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Bug has been fixed with this MR[1].
[1]: https:/