upstream all and rdo tox jobs broken due to cannot import name ensure_text

[Sorin Sbarnea]

tox is failing to run on lots of nodepool nodesets because of virtualenv20/six issues.

I created a testproject change that checks most impostant nodesets against an empty tox.ini file.

All of these where supposed to pass but we got only two of them working, this means that any tox job trying to use these jobs will not run.

https://review.rdoproject.org/r/24916

This is related to https://trello.com/c/vibb9vo7/1329-cixlp1862724 -- caused by the same root cause (newer virtualenv).

[wes hayutin (weshayutin)]

it's hitting upstream again

2020-02-12 22:40:37.721220 | primary | Package python-virtualenv-15.1.0-2.el7.noarch already installed and latest version
2020-02-12 22:40:37.798432 | primary | Nothing to do
2020-02-12 22:40:38.090926 | primary | checking python modules
2020-02-12 22:40:38.171304 | primary | pip:20.0.2 Traceback (most recent call last):
2020-02-12 22:40:38.171450 | primary | File "<string>", line 1, in <module>
2020-02-12 22:40:38.171647 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/__init__.py", line 3, in <module>
2020-02-12 22:40:38.171730 | primary | from .run import cli_run
2020-02-12 22:40:38.171957 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/run/__init__.py", line 5, in <module>
2020-02-12 22:40:38.172107 | primary | from ..config.cli.parser import VirtualEnvConfigParser
2020-02-12 22:40:38.172314 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/config/cli/parser.py", line 6, in <module>
2020-02-12 22:40:38.172421 | primary | from ..ini import IniConfig
2020-02-12 22:40:38.172619 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/config/ini.py", line 8, in <module>
2020-02-12 22:40:38.172792 | primary | from virtualenv.dirs import default_config_dir
2020-02-12 22:40:38.173013 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/dirs.py", line 5, in <module>
2020-02-12 22:40:38.173146 | primary | from virtualenv.util.lock import ReentrantFileLock
2020-02-12 22:40:38.173338 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/util/lock.py", line 11, in <module>
2020-02-12 22:40:38.173443 | primary | from virtualenv.util.path import Path
2020-02-12 22:40:38.173651 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/util/path/__init__.py", line 5, in <module>
2020-02-12 22:40:38.173814 | primary | from ._sync import copy, copytree, ensure_dir, link, symlink
2020-02-12 22:40:38.174023 | primary | File "/usr/lib/python2.7/site-packages/virtualenv/util/path/_sync.py", line 7, in <module>
2020-02-12 22:40:38.174129 | primary | from six import PY2, PY3, ensure_text
2020-02-12 22:40:38.174257 | primary | ImportError: cannot import name ensure_text
2020-02-12 22:40:38.386388 | primary | setuptools:44.0.0 ERROR: virtualenv not installed
2020-02-12 22:40:38.903446 | primary | ERROR
2020-02-12 22:40:38.903865 | primary | {
2020-02-12 22:40:38.903978 | primary | "delta": "0:00:13.932137",
2020-02-12 22:40:38.904081 | primary | "end": "2020-02-12 22:40:38.387960",
2020-02-12 22:40:38.904180 | primary | "msg": "non-zero return code",
2020-02-12 22:40:38.904278 | primary | "rc": 1,
2020-02-12 22:40:38.904375 | primary | "start": "2020-02-12 22:40:24.455823"
2020-02-12 22:40:38.904472 | primary | }
2020-02-12 22:40:39.154581 |

https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4de/707330/4/gate/tripleo-ci-centos-7-containers-multinode-train/4de8a57/job-output.txt

[wes hayutin (weshayutin)]

fyi
https://review.opendev.org/#/c/707499/ building pip into images

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/707505

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/707525

[wes hayutin (weshayutin)]

upstream fix for tripleo jobs is here:
https://review.opendev.org/#/c/707525/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707525
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=cd0b737930ad706d090550cc03a90bd80d683cba
Submitter: Zuul
Branch: master

commit cd0b737930ad706d090550cc03a90bd80d683cba
Author: Wes Hayutin <email address hidden>
Date: Wed Feb 12 20:39:49 2020 -0700

    workaround for virtualenv dep issues

    six >= 1.12 is needed with virtualenv>=20.0.

    Partial-Bug: #1862941
    Change-Id: I6bb0141c0a54b6ab069d1f6e6ab65c5bf34ee703

[OpenStack Infra (hudson-openstack)]

Change abandoned by wes hayutin (<email address hidden>) on branch: master
Review: https://review.opendev.org/707505

[Marios Andreou (marios-b)]

tripleo-ci master: Add explicit six>=1.14.0 for build-containers role venv_setup https://review.opendev.org/707675

[Marios Andreou (marios-b)]

@zbr (ping) do we need to keep this bug around? AFAIK we have landed a workaround in all the places as above, but is there a proper fix coming we need to track here and then undo all those hacks?

[Sorin Sbarnea (ssbarnea)]

We can now close it because both virtualenv and tox had newer releases that are not affected by this issue.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/708380

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sorin Sbarnea (<email address hidden>) on branch: master
Review: https://review.opendev.org/708380
Reason: I think all changes are obsoleted.