【pcie-0212】PCI/AER: Fix the uninitialized aer_fifo

Bug #1862868 reported by Fred Kimmy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kunpeng920
Fix Released
Undecided
Unassigned
Ubuntu-18.04
Invalid
Undecided
Ike Panhc
Ubuntu-18.04-hwe
Fix Released
Undecided
Ike Panhc
Ubuntu-20.04
Fix Released
Undecided
Ike Panhc
Upstream-kernel
Fix Released
Undecided
Unassigned

Bug Description

[Bug Description]

Current code do not call INIT_KFIFO() to init aer_fifo. This will lead to
kfifo_put() sometimes return 0. This means the fifo was full. In fact, it
is not. It is easy to reproduce the problem by using aer_inject.
aer_inject -s :82:00.0 multiple-corr-nonfatal
The content of multiple-corr-nonfatal file is as below.
AER
COR RCVR
HL 0 1 2 3
AER
UNCOR POISON_TLP
HL 4 5 6 7

Fixes: 27c1ce8bbed7 ("PCI/AER: Use kfifo for tracking events instead of reimplementing it")
Signed-off-by: Dongdong Liu <email address hidden>

[Steps to Reproduce]
1)
2)
3)

[Actual Results]

[Expected Results]

[Reproducibility]

[Additional information]
(Firmware version, kernel version, affected hardware, etc. if required):

[Resolution]

PCI/AER: Fix the uninitialized aer_fifo

Revision history for this message
Ike Panhc (ikepanhc) wrote :

Not yet in mainline kernel.

ikepanhc@Kira:~/Canonical/sandbox$ git reset --hard origin/master
HEAD is now at 359c92c02bfa Merge tag 'dax-fixes-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
ikepanhc@Kira:~/Canonical/sandbox$ gitoneline | grep 'Fix the uninitialized aer_fifo'
ikepanhc@Kira:~/Canonical/sandbox$

Changed in kunpeng920:
status: New → Incomplete
Revision history for this message
Ike Panhc (ikepanhc) wrote :

$ gitoneline | grep aer_fifo
d95f20c4f070 <email address hidden> 2020-01-23 16:40:03 -0600 PCI/AER: Initialize aer_fifo

Patch has been merged into mainline kernel in 5.6 merge window

Ike Panhc (ikepanhc)
Changed in kunpeng920:
status: Incomplete → In Progress
Revision history for this message
Ike Panhc (ikepanhc) wrote :

This patch fixes Fixes: 27c1ce8bbed7 ("PCI/AER: Use kfifo for tracking events instead of reimplementing it") which is introduced into mainline kernel since 5.0, so no need for 4.15 kernel.

Revision history for this message
Ike Panhc (ikepanhc) wrote :

In focal kernel since 5.4.0-15.18

Changed in kunpeng920:
status: In Progress → Fix Committed
Ike Panhc (ikepanhc)
Changed in kunpeng920:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.