add and keep FROM register reset the date

[Nicolas]

Hello, I have recently upgraded from 5.2.8 to 5.3.2 (Windows), and I noticed a change in how "Add & Keep" button works for transactions.

To make sure it is not related to my personal setup, I have made sure to reproduce the bug using clean portable installs.

Here is what I did:

- Download 5.2.8 from http://homebank.free.fr/public/HomeBank-5.2.8-setup.exe
- Make a portable install somewhere
- Launch HomeBank
- Create a new account
- Open transactions
- Add a new transaction
- Set date in the past
- Click on "Add & Keep"
- Result: date is kept
- GIF in action of previous steps: https://i.imgur.com/oNjRxgK.gifv

- Download 5.3.2 from http://homebank.free.fr/public/HomeBank-5.3.2-setup.exe
- Make a portable install somewhere
- Launch HomeBank
- Create a new account
- Open transactions
- Add a new transaction
- Set date in the past
- Click on "Add & Keep"
- Result: date is NOT kept
- GIF in action of previous steps: https://i.imgur.com/OTSKHmt.gifv

Is this a bug related to "change: transaction dialog layout change" from 5.3?

Thanks for reading.

[Maxime DOYEN (mdoyen)]

but no in fact, as, this is due to a fix for #1858945

[Nicolas (nicolas-beauchamp35)]

Do you mean it actually was bugged in 5.2? If so, I find this very sad.

I think it makes more sense if "Add & Keep" does NOT reset the date. "Add" resetting date to today makes sense because everything is reset, but "Add & Keep" keeping everything EXCEPT the date does not make sense to me.

This may also just be me, but I find it very convenient because I use "Add & Keep" a lot, in order to split transactions in two: one half in my account, the other half as a internal transfer between my account and a tracking account for lending/refunding money, as mentioned in the "Final note" of "Lend/Refund money" from the manual.

[Maxime DOYEN (mdoyen)]

No, I mean I broke someting with 5.3 and made afirst fix with #1858945

BUT there still a bug from the register

From both main or register in 5.2.8 the behavior is the same:

prefs: keep the last date = OFF
- add & keep : keep all (including date)
- add : reset all, date=today

prefs: keep the last date = ON
- add & keep : keep all (including date)
- add : reset all, date keeped

the remaining bug in 5.3.2 is:
prefs: keep the last date = OFF
- from register, add & keep reset date to today's (and should not)