cinder retype corrupts volume in some scenarios

[Magnus Bergman]

When converting from NFS to CEPH retype will not convert a qcow source to raw before writing it to the destination volume. This might be applicable to other backends as well and results in a corrupt destination volume.

It will just read the qcow file and write it to ceph without converting it to raw. In this specific case it will use _copy_volume_with_file() with the source as a path and the destination as a RawIOBase so we could probably not use qemu-img convert on the fly in any way, but would have to convert it (to a temporary file) before the actual transfer of the data to the destination takes place. Another option could be to nbd mount the qcow - but that comes with it's own bunch of potential issues and requirements.

[Dmitriy Rabotyagov (noonedeadpunk)]

I have only nasty solution for this. But I don't really see an appropriate one, unfrotunatelly...

[Dmitriy Rabotyagov (noonedeadpunk)]

Here is more proper solution, but it still needs work. I guess temporary created drive in raw format should be probably managed, and then properly removed. Not having time for this unfortunatelly...