[OVN] functional test test_virtual_port_delete_parents is unstable

[Maciej Jozefczyk]

Functional test:

neutron.tests.functional.plugins.ml2.drivers.ovn.mech_driver.test_mech_driver.TestVirtualPorts.test_virtual_port_delete_parents

randomly fails with:

ft1.2: neutron.tests.functional.plugins.ml2.drivers.ovn.mech_driver.test_mech_driver.TestVirtualPorts.test_virtual_port_delete_parentstesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.6/site-packages/mock/mock.py", line 1330, in patched
    return func(*args, **keywargs)
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 182, in func
    return f(self, *args, **kwargs)
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py", line 376, in test_virtual_port_delete_parents
    self.assertEqual("", ovn_vport.type)
  File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.6/site-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.6/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: '' != 'virtual'

[Sapna Jadhav (sapana45)]

Hi Maciej,
If you haven't started working on this, can I work on this?

[Maciej Jozefczyk (maciejjozefczyk)]

Hey!

Yes, feel free to take it if you have time!

Thanks

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/710722

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710722
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=08132e213d90772af3a2e34b62a8094ec86ab06e
Submitter: Zuul
Branch: master

commit 08132e213d90772af3a2e34b62a8094ec86ab06e
Author: Maciej Józefczyk <email address hidden>
Date: Mon Mar 2 09:59:58 2020 +0100

    Change way of retrieving LSP in virtual_port functional tests

    Sometimes we had a situation, where Logical_Switch_Port type
    received by IDL had a different type, that type set in the
    NBDB. We changed the way we retrieve the LS from DB, to not
    loop over rows in table, but call db_find_rows() instead.
    With this change after about 40 retries of functional tests we
    don't spot the same issue again.

    Change-Id: I07c081d1984b26a10a4d854d17117cfeaac7f8ac
    Related-Bug: 1862618