rally creates router on network different to [network] public_network_id

[Will Szumski]

Using the rally tempest verifier I got the following trace:

    Neutron server returns request_ids: ['req-38fb9ed0-03c7-4e4c-80f9-17ac24f0cdc2']
    2020-02-04 12:15:02.225 19 ERROR rally Traceback (most recent call last):
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/bin/rally", line 8, in <module>
    2020-02-04 12:15:02.225 19 ERROR rally sys.exit(main())
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/cli/main.py", line 42, in main
    2020-02-04 12:15:02.225 19 ERROR rally return cliutils.run(sys.argv, categories)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/cli/cliutils.py", line 674, in run
    2020-02-04 12:15:02.225 19 ERROR rally ret = fn(*fn_args, **fn_kwargs)
    2020-02-04 12:15:02.225 19 ERROR rally File "<decorator-gen-92>", line 2, in start
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/cli/envutils.py", line 68, in default_from_global
    2020-02-04 12:15:02.225 19 ERROR rally return f(*args, **kwargs)
    2020-02-04 12:15:02.225 19 ERROR rally File "<decorator-gen-91>", line 2, in start
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/cli/envutils.py", line 68, in default_from_global
    2020-02-04 12:15:02.225 19 ERROR rally return f(*args, **kwargs)
    2020-02-04 12:15:02.225 19 ERROR rally File "<decorator-gen-90>", line 2, in start
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/plugins/__init__.py", line 51, in ensure_plugins_are_loaded
    2020-02-04 12:15:02.225 19 ERROR rally return f(*args, **kwargs)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/cli/commands/verify.py", line 515, in start
    2020-02-04 12:15:02.225 19 ERROR rally tags=tags, **run_args)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/api.py", line 1037, in start
    2020-02-04 12:15:02.225 19 ERROR rally with vcontext.ContextManager(context):
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/task/context.py", line 311, in __enter__
    2020-02-04 12:15:02.225 19 ERROR rally self.setup()
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally/task/context.py", line 256, in setup
    2020-02-04 12:15:02.225 19 ERROR rally ctx.setup()
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally_openstack/verification/tempest/context.py", line 97, in setup
    2020-02-04 12:15:02.225 19 ERROR rally helper_method=self._create_network_resources)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally_openstack/verification/tempest/context.py", line 143, in _configure_option
    2020-02-04 12:15:02.225 19 ERROR rally res = helper_method(*args, **kwargs)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally_openstack/verification/tempest/context.py", line 281, in _create_network_resources
    2020-02-04 12:15:02.225 19 ERROR rally network_create_args={"shared": True})
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally_openstack/wrappers/network.py", line 236, in create_network
    2020-02-04 12:15:02.225 19 ERROR rally router = self.create_router(**router_args)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/rally_openstack/wrappers/network.py", line 176, in create_router
    2020-02-04 12:15:02.225 19 ERROR rally return self.client.create_router({"router": kwargs})["router"]
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/neutronclient/v2_0/client.py", line 885, in create_router
    2020-02-04 12:15:02.225 19 ERROR rally return self.post(self.routers_path, body=body)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/neutronclient/v2_0/client.py", line 359, in post
    2020-02-04 12:15:02.225 19 ERROR rally headers=headers, params=params)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/neutronclient/v2_0/client.py", line 294, in do_request
    2020-02-04 12:15:02.225 19 ERROR rally self._handle_fault_response(status_code, replybody, resp)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/neutronclient/v2_0/client.py", line 269, in _handle_fault_response
    2020-02-04 12:15:02.225 19 ERROR rally exception_handler_v20(status_code, error_body)
    2020-02-04 12:15:02.225 19 ERROR rally File "/usr/local/lib/python2.7/dist-packages/neutronclient/v2_0/client.py", line 93, in exception_handler_v20
    2020-02-04 12:15:02.225 19 ERROR rally request_ids=request_ids)
    2020-02-04 12:15:02.225 19 ERROR rally IpAddressGenerationFailureClient: No more IP addresses available on network 9e59fc9e-61d7-4ebe-91ee-7c179a98a703.
    2020-02-04 12:15:02.225 19 ERROR rally Neutron server returns request_ids: ['req-38fb9ed0-03c7-4e4c-80f9-17ac24f0cdc2']
    2020-02-04 12:15:02.225 19 ERROR rally [00m
    Command failed, please check log for more info

despite using the the following override:

  [network]
  public_network_id = my-uuid

in my tempest.conf.

expected behaviour: use public_network_id from tempest.conf when creating the router

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/706229
Committed: https://git.openstack.org/cgit/openstack/rally-openstack/commit/?id=ceb96360240f3efe47a5ccf2ec620535a1c51d76
Submitter: Zuul
Branch: master

commit ceb96360240f3efe47a5ccf2ec620535a1c51d76
Author: Will Szumski <email address hidden>
Date: Thu Feb 6 10:39:05 2020 +0000

    Use public_network_id when creating router

    Previously if using tempest overrides with:

      [network]
      public_network_id = my-uuid

    rally could create a router on a different network.

    Closes-Bug: #1862036
    Change-Id: I0ed958f07b7cfeab3a27cbff530290e832740077

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/rally-openstack 1.7.0 release.