Mistral

LegacyScheduler doesn't assign the "key" property of delayed calls

Bug #1861988 reported by Renat Akhmerov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Critical
Renat Akhmerov
Mistral ussuri-2 "u-2"

Bug Description

The field "key" of DelayedCall is always None. Due to that, has_scheduled_jobs() method of the legacy scheduler doesn't work properly. And it leads to a big performance regression for workflows with many "join" tasks.

Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

The patch that addresses it: https://review.opendev.org/#/c/705635/

tags: added: backport train
Changed in mistral:
assignee: nobody → Renat Akhmerov (rakhmerov)
milestone: none → ussuri-2
importance: Undecided → Critical
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.opendev.org/705635
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=5b5576dd04ac596b619ee61e0aa837effd319c49
Submitter: Zuul
Branch: master

commit 5b5576dd04ac596b619ee61e0aa837effd319c49
Author: Renat Akhmerov <email address hidden>
Date: Tue Feb 4 18:36:15 2020 +0700

    Set the delayed call "key" field to the right value

    * The field "key" of the DelayedCall class must be set to the right
      value. It allows to significantly optimize performance of workflows
      with "join" tasks. However, it was broken during the refactoring
      in the summer of 2019. This patch fixes it.
    * Added another profiler trace decorator.

    Closes-Bug: #1861988
    Change-Id: I247b674d8a358795871cfa87bcdf29f4857ca2d8

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/train)

Reviewed: https://review.opendev.org/705900
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=7c54c28c4c38ad1a71bf4388ffb1fe70200b373e
Submitter: Zuul
Branch: stable/train

commit 7c54c28c4c38ad1a71bf4388ffb1fe70200b373e
Author: Renat Akhmerov <email address hidden>
Date: Tue Feb 4 18:36:15 2020 +0700

    Set the delayed call "key" field to the right value

    * The field "key" of the DelayedCall class must be set to the right
      value. It allows to significantly optimize performance of workflows
      with "join" tasks. However, it was broken during the refactoring
      in the summer of 2019. This patch fixes it.
    * Added another profiler trace decorator.

    Cherry-picked from 5b5576dd04ac596b619ee61e0aa837effd319c49

    Closes-Bug: #1861988
    Change-Id: I247b674d8a358795871cfa87bcdf29f4857ca2d8

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 10.0.0.0b2

This issue was fixed in the openstack/mistral 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.