[Stein to Train] Upgrade fails with: 'cinder_backup_docker_image_latest' is undefined

Bug #1861475 reported by Jose Luis Franco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Jose Luis Franco

Bug Description

When upgrading from Stein to Train, in the Controller's role upgrading step, the "overcloud upgrade run" command fails in the following task:

2020-01-30 23:13:11 | TASK [tripleo-container-tag : Pull 192.168.24.1:8787/rh-osbs/rhosp15-openstack-cinder-backup:pcmklatest image] ***
2020-01-30 23:13:11 | Thursday 30 January 2020 23:13:10 +0000 (0:00:00.419) 0:01:42.429 ******
2020-01-30 23:13:11 | skipping: [controller-0] => {"changed": false, "skip_reason": "Conditional result was False"}
2020-01-30 23:13:11 | skipping: [controller-1] => {"changed": false, "skip_reason": "Conditional result was False"}
2020-01-30 23:13:11 | skipping: [controller-2] => {"changed": false, "skip_reason": "Conditional result was False"}
2020-01-30 23:13:11 |
2020-01-30 23:13:11 | TASK [tripleo-container-tag : Tag {{ tripleo_container_image_latest }} to latest {{ tripleo_container_image }} image] ***
2020-01-30 23:13:11 | Thursday 30 January 2020 23:13:10 +0000 (0:00:00.457) 0:01:42.886 ******
2020-01-30 23:13:11 | fatal: [controller-0]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'cinder_backup_docker_image_latest' is undefined\n\nThe error appears to be in '/usr/share/ansible/roles/tripleo-container-tag/tasks/main.yml': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Tag {{ tripleo_container_image_latest }} to latest {{ tripleo_container_image }} image\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be written as:\n\n with_items:\n - \"{{ foo }}\"\n"}
2020-01-30 23:13:11 | fatal: [controller-1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'cinder_backup_docker_image_latest' is undefined\n\nThe error appears to be in '/usr/share/ansible/roles/tripleo-container-tag/tasks/main.yml': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Tag {{ tripleo_container_image_latest }} to latest {{ tripleo_container_image }} image\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be written as:\n\n with_items:\n - \"{{ foo }}\"\n"}
2020-01-30 23:13:11 | fatal: [controller-2]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'cinder_backup_docker_image_latest' is undefined\n\nThe error appears to be in '/usr/share/ansible/roles/tripleo-container-tag/tasks/main.yml': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Tag {{ tripleo_container_image_latest }} to latest {{ tripleo_container_image }} image\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be written as:\n\n with_items:\n - \"{{ foo }}\"\n"}
2020-01-30 23:13:11 |
2020-01-30 23:13:11 | NO MORE HOSTS LEFT *************************************************************
2020-01-30 23:13:11 |
2020-01-30 23:13:11 | PLAY RECAP *********************************************************************
2020-01-30 23:13:11 | controller-0 : ok=8 changed=4 unreachable=0 failed=1 skipped=2 rescued=0 ignored=0
2020-01-30 23:13:11 | controller-1 : ok=6 changed=2 unreachable=0 failed=1 skipped=2 rescued=0 ignored=0
2020-01-30 23:13:11 | controller-2 : ok=6 changed=2 unreachable=0 failed=1 skipped=2 rescued=0 ignored=0
2020-01-30 23:13:11 |
2020-01-30 23:13:11 | Thursday 30 January 2020 23:13:10 +0000 (0:00:00.292) 0:01:43.178 ******
2020-01-30 23:13:11 | ===============================================================================
2020-01-30 23:13:11 |
2020-01-30 23:13:11 | Ansible failed, check log at /var/lib/mistral/72438451-13b6-4841-a213-a3ff0757773b/ansible.log.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/705162

Changed in tripleo:
assignee: nobody → Jose Luis Franco (jfrancoa)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/705162
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=436ea96660d75fb7a6476b4bd05d954b621fe822
Submitter: Zuul
Branch: master

commit 436ea96660d75fb7a6476b4bd05d954b621fe822
Author: Jose Luis Franco Arza <email address hidden>
Date: Fri Jan 31 07:41:15 2020 +0100

    Fix undefined variable in cinder_backup service.

    cinder_backup_docker_image_latest ansible variable wasn't
    existing anymore, as it was changed into cinder_backup_image_latest.

    Change-Id: I0fdef9becf9cc23786180c3399ca09461a916114
    Closes-Bug:#1861475

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/705409

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/706807

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/705409
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b2f6cee43bd8045ae74ff6f4797ac8d1d28d5b99
Submitter: Zuul
Branch: stable/train

commit b2f6cee43bd8045ae74ff6f4797ac8d1d28d5b99
Author: Jose Luis Franco Arza <email address hidden>
Date: Fri Jan 31 07:41:15 2020 +0100

    Fix undefined variable in cinder_backup service.

    cinder_backup_docker_image_latest ansible variable wasn't
    existing anymore, as it was changed into cinder_backup_image_latest.

    Depends-On: https://review.opendev.org/#/c/706196/
    Change-Id: I0fdef9becf9cc23786180c3399ca09461a916114
    Closes-Bug:#1861475
    (cherry picked from commit 436ea96660d75fb7a6476b4bd05d954b621fe822)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/stein)

Change abandoned by Jesse Pretorius (odyssey4me) (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/706807
Reason: Temporary to unblock gates until https://review.opendev.org/#/c/707330/5 merges.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.1.0

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/706807
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6f39dd36eb1dfe1d581b33df0bf7d8db020a4139
Submitter: Zuul
Branch: stable/stein

commit 6f39dd36eb1dfe1d581b33df0bf7d8db020a4139
Author: Jose Luis Franco Arza <email address hidden>
Date: Fri Jan 31 07:41:15 2020 +0100

    Fix undefined variable in cinder_backup service.

    cinder_backup_docker_image_latest ansible variable wasn't
    existing anymore, as it was changed into cinder_backup_image_latest.

    Change-Id: I0fdef9becf9cc23786180c3399ca09461a916114
    Closes-Bug:#1861475
    (cherry picked from commit 436ea96660d75fb7a6476b4bd05d954b621fe822)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates stein-eol

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.