asking about local vs remote inconsistent between add-cloud and add-credential

[Richard Harding]

When adding a cloud I get dropped straight into the workflow and selecting the type, submitting a name, etc. Only at the end do I get the question of adding this new cloud locally or on a controller. I prefer this workflow personally.

When you add a credential you get distracted right off the bat.

    This operation can be applied to both a copy on this client and to the one on a controller.
    No current controller was detected and there are no registered controllers on this client:
    either bootstrap one or register one.
    Do you ONLY want to add a credential to this client? (Y/n):

In this case where I have no controllers I also get questioned about a controller when there is none which seems unnecessary.

It'd be smoother if the commands were more consistent with their workflows.

[Richard Harding (rharding)]

Interestingly the credentials command deals with the lack of a controller much better. This would be great to also be more consistent.

% juju credentials
No credentials from any controller to display.

Client Credentials:
Cloud Credentials
google company
guimaas rharding
guimaas-ip rharding
localhost localhost*

[Anastasia (anastasia-macmood)]

Summarizing here our off-line discussion:

1. There is discrepancy when the prompt for client/controller operation happens between commands because some commands, and add-credential is one of them, need to know where the operation happens early as they validate if the cloud exists at the destination. So for consistency sake, it makes sense to prompt first everywhere.

2. If there are no controllers registered on the client, there is no point prompting for location of the operation. We can safely assume that the destination is client. I'll change the prompt accordingly.

3. For read-only commands - lists and show- - we will always try to list both client and controller information without prompting.

[Anastasia (anastasia-macmood)]

I will solve all 3 parts against 2.7 first and then will merge 2.7 into develop.

Part 1 PR: https://github.com/juju/juju/pull/11264 Turns out that 'add-cloud' command was the only inconsistent command. All other commands in the package prompt for client/controller first.

[Anastasia (anastasia-macmood)]

I have just confirmed in the code that all read-only commands do not prompt, so Part 3 has already been catered for in 2.7 and develop.

[Anastasia (anastasia-macmood)]

It seems like Part 3 has regressed in develop but works in 2.7. I'll have a look as part of this work.

[Anastasia (anastasia-macmood)]

Part 2 PR for 2.7: https://github.com/juju/juju/pull/11265

[Anastasia (anastasia-macmood)]

'juju clouds' behavior regressed. This PR fixes regression in develop: https://github.com/juju/juju/pull/11266

[Anastasia (anastasia-macmood)]

Bringing 2.7 changes into develop is included in this PR: https://github.com/juju/juju/pull/11270

[Anastasia (anastasia-macmood)]

Change into develop is being brought in by https://github.com/juju/juju/pull/11271