Not able to edit invoice item type Code

[Tiffany Little]

Tested on 3.4.1 and 3.3.

I am not able to edit existing invoice item types. The modal opens to edit, and I get the success toast when I hit Save, but no changes are made.

I'm able to create new item types fine.

[Bill Erickson (berick)]

Tiffany, can you confirm the issue relates specifically to modifying the invoice item type "Code" value? I was unable modify Code's in both the old and new invoice item type interfaces. I was able to edit other values, though.

[Tiffany Little (tslittle)]

Bill, you are correct! I'm able to change other values (prorate yes/no, and the label), but cannot edit the code. I don't think I ever changed an invoice item type code when it was in Dojo, so had no idea that wasn't possible.

Is there a reason we shouldn't be able to edit the code, or would that be the bug?

[Tiffany Little (tslittle)]

Oh, I see--the code is the primary key. Follow-up question: can we not just add an id field to that table so that the code is no longer the PK? That would be more consistent with other tables, and I can see wanting to edit the code.

[Bill Erickson (berick)]

Thanks for confirming, Tiffany.

Options that come to mind:

1. Make it non-changeable in the UI, requiring changes be made directly in the database. This is a trivial IDL change.

2. Add an API or stored procedure to support changing the value, which would also update any rows linked to the pkey from other tables (e.g. acq.invoice_item).

3. As suggested, add an ID surrogate key to the invoice_item_type table. This would resolve the update-ability but adds other complications at the SQL level. (We've been talking about dropping the ID from permission.perm_list table for a long time, because it complicates SQL upgrades).