[OVS] VLAN tag should be set in the Port register, not the Interface

[Rodolfo Alonso]

In OVS, the VLAN tag for a device is set in the Port register, not the Interface [1][2]. Method "BaseOVS.create_ovs_vif_port" [3] should implement it.

[1] http://docs.openvswitch.org/en/latest/faq/configuration/
[2] https://github.com/openstack/neutron/blob/1d354f75776fca6bf12beae70f7e3206459c84c4/neutron/agent/common/ovs_lib.py#L346-L347
[3] https://github.com/openstack/os-vif/blob/7bad0f93bbda1238fa3d853ce428f92d8606b360/vif_plug_ovs/ovsdb/ovsdb_lib.py#L63

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/703373

[sean mooney (sean-k-mooney)]

once this is merged ill start submitting the backport but we should bring this back to all releases where we have the security feature.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703373
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=d5b61d10655b3b7a9d32378b5f7bcdb06479e15d
Submitter: Zuul
Branch: master

commit d5b61d10655b3b7a9d32378b5f7bcdb06479e15d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jan 20 11:41:24 2020 +0000

    [OVS] VLAN tag should be set in the Port register

    In OVS, the VLAN tag for a device is set in the Port register,
    not the Interface [1][2]. Method "BaseOVS.create_ovs_vif_port"
    should implement it.

    [1] http://docs.openvswitch.org/en/latest/faq/configuration/
    [2] https://github.com/openstack/neutron/blob/1d354f75776fca6bf12beae70f7e3206459c84c4/neutron/agent/common/ovs_lib.py#L346-L347

    Change-Id: Iaebd42af6d5b8e3165cf10e269addae0ff3665fb
    Closes-Bug: #1860329

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 2.0.0 release.