A/T ApplyPatronPenalty reactor misreads environment

[Jason Etheridge]

In the handler for ApplyPatronPenalty.pm, we have:

    my $user = $$env{environment}{user};
    my $context_org = $$env{environment}{context_org};

It should be:

    my $user = $$env{user};
    my $context_org = $$env{context_org};

user and context_org are labels for their corresponding environment path entries.

I'll throw a patch up once LP gives me a bug number.

[Jason Etheridge (phasefx)]

There was also a typo that this patch fixes:

collab/phasefx/lp1859502-ApplyPatronPenalty @ working/Evergreen.git

    To test this, you could create the following A/T definition:

        Owning Library: CONS
        Name: test lp1859502
        Hook: penalty.PATRON_EXCEEDS_FINES
        Enabled: True
        Processing Delay: 00:00:00
        Processing Group Context Field: usr
        Reactor: ApplyPatronPenalty
        Validator: NOOP_TRUE
        Max Event Validity Delay: 1 day
        Template: test message

    with environment:

        Field Path: usr
        Label: user

        Field Path: usr.home_ou
        Label: context_org

    with event params:

        Parameter Name: standing_penalty
        Parameter Value: ALERT_NOTE

    Then bill a test patron for $100 and run something like:

    /openils/bin/action_trigger_runner.pl --osrf-config /openils/conf/opensrf_core.xml --run-pending

    Without the patch, you'll get something like this in osrfsys.log:

    ApplyPatronPenalty: missing parameters

    And no ALERT_NOTE penalty. With the patch you should see a "test message" alert note
    when reloading the patron.

[Chris Sharp (chrissharp123)]

Works for me! Pushed to master, rel_3_7 and rel_3_6. Thanks, Jason.